-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discover] Extract discover grid flyout from discover grid component #147403
[discover] Extract discover grid flyout from discover grid component #147403
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , it's much simpler than expected, which is : great! just added an suggestion to further simplify the code. Tested locally and works as expected
src/plugins/discover/public/components/discover_grid/discover_grid.tsx
Outdated
Show resolved
Hide resolved
…ttkime/kibana into discover_document_detail_outside_grid
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Extract discover grid flyout from discover grid component. Part of effort to turn discover into set of components consumable by other kibana apps.
Closes #144154