Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover] Extract discover grid flyout from discover grid component #147403

Merged
merged 10 commits into from
Dec 16, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Dec 12, 2022

Summary

Extract discover grid flyout from discover grid component. Part of effort to turn discover into set of components consumable by other kibana apps.

Closes #144154

@mattkime mattkime changed the title first attempt [discover] Extract discover grid flyout from discover grid component Dec 16, 2022
@mattkime mattkime marked this pull request as ready for review December 16, 2022 01:58
@mattkime mattkime requested a review from a team as a code owner December 16, 2022 01:58
@mattkime mattkime added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Dec 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , it's much simpler than expected, which is : great! just added an suggestion to further simplify the code. Tested locally and works as expected

@mattkime mattkime enabled auto-merge (squash) December 16, 2022 15:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 418.1KB 418.4KB +233.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 440 446 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 517 523 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit e43ccd1 into elastic:main Dec 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Extract DiscoverGridFlyout from DiscoverGrid component
5 participants