Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Monitor select append location id #148523

Merged
merged 3 commits into from
Jan 9, 2023
Merged

[Synthetics] Monitor select append location id #148523

merged 3 commits into from
Jan 9, 2023

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes #146057

Monitor select append location id in monitor url

image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.3MB 1.3MB +282.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review January 9, 2023 15:04
@shahzad31 shahzad31 requested a review from a team as a code owner January 9, 2023 15:04
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Jan 9, 2023
dominiqueclarke
dominiqueclarke approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Switching now switches to a relevant location.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit f94c7ad into elastic:main Jan 9, 2023
@shahzad31 shahzad31 deleted the monitor-select-location branch January 9, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
Milestone
No milestone
4 participants
@shahzad31 @kibana-ci @elasticmachine @dominiqueclarke