Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Controls] Backport flaky test fix #148662

Merged
merged 1 commit into from
Jan 10, 2023
Merged

[Dashboard] [Controls] Backport flaky test fix #148662

merged 1 commit into from
Jan 10, 2023

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 10, 2023 •
edited
Loading

Closes #146086

Summary

Backports the flaky test fix from #144867 to 8.6

@Heenawter Heenawter self-assigned this Jan 10, 2023
@Heenawter Heenawter added release_note:skip Skip the PR/issue when compiling release notes v8.6.1 Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Controls labels Jan 10, 2023
@Heenawter Heenawter force-pushed the flaky-control-test-fix_2023-01-10 branch from 0e0daea to e5652ed Compare January 10, 2023 17:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@Heenawter Heenawter marked this pull request as ready for review January 10, 2023 20:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 10, 2023
ThomThomson
ThomThomson approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Heenawter Heenawter merged commit fd942d8 into elastic:8.6 Jan 10, 2023
@Heenawter Heenawter mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@Heenawter Heenawter

Labels
Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Heenawter @kibana-ci @elasticmachine @ThomThomson