Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tooltip show all series #14914

Closed
wants to merge 2 commits into from
Closed

make tooltip show all series #14914

wants to merge 2 commits into from

Conversation

shaharmor
Copy link
Contributor

related to #13864 (Maybe it fixes it?)

This PR makes the TSVB tooltip show a row for each series.
It also aligns the value to the right end of the tooltip for consistency with the newly added values

@simianhacker I wasn't sure how to align the tooltip correctly.
When there are multiple yaxis, the tooltip can be rendered below/above the chart in some cases.

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@thomasneirynck thomasneirynck added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 13, 2017
@thomasneirynck
Copy link
Contributor

jenkins, test this

simianhacker
simianhacker requested changes Nov 13, 2017
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should come up with some kind of max width and then truncate the label with ellipsis.

image

@shaharmor
Copy link
Contributor Author

Right. I'll do that tomorrow.
What about the position? If there are multiple Y axis the position of the tooltip is kinda messed up (Unrelated to this PR).

@mattapperson
Copy link
Contributor

@shaharmor bump on this in prep to get all TSVB PRs closed before we move it to prettier formatted

@shaharmor
Copy link
Contributor Author

@mattapperson @simianhacker done. PR rebased.

shaharmor
shaharmor commented Nov 23, 2017
View reviewed changes
src/ui/public/visualize/visualize.less
@@ -5,7 +5,6 @@ visualization {
flex-direction: column;
height: auto;
width: 100%;
overflow: auto;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be checked with kibana vis team.
When overflow: auto, if the tooltip is high, it crosses the panel dimensions and gets cut.
Without overflow, the tooltip simply goes beyond the panel (Which is fine I guess).
I didn't find any other issues with it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably best to leave this change out. EUI has a new tooltip component which should be (if not already) an easy fit into TSVB.

@simianhacker @mattapperson does TSVB use EUI tooltip yet, or is it in the near future?

@tsullivan
Copy link
Member

If this is going to go in, it needs a bump from @simianhacker to re-review after the changes and @mattapperson to give a review. Let's try to get it sooner rather than later while it still can be merged without conflicts.

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@markov00
Copy link
Member

Hey @simianhacker @elastic/kibana-app can you take another look at the changes?

Hey @shaharmor can you rebase? all the .less styles is now refactored to SASS.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tsullivan
Copy link
Member

Ping @shaharmor

@elastic elastic deleted a comment from elasticmachine Mar 8, 2019
@markov00 markov00 mentioned this pull request Mar 8, 2019
Closed
5 tasks
@tsullivan
Copy link
Member

Closing as it looks like interest has dropped on this.

This will also be solved when the TSVB timeseries chart has the new chart library replacement.

@tsullivan tsullivan closed this Mar 11, 2019
@shaharmor
Copy link
Contributor Author

Interest has not dropped, I just didn't have the time to rebase yet.
We're using this feature in production already, and it has been a year and a half since I posted this PR, so coming back to it will take more time.

If you say this will already be fixed in the new TSVB, we can just wait for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan left review comments

@simianhacker simianhacker simianhacker requested changes

@mattapperson mattapperson Awaiting requested review from mattapperson

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shaharmor @elasticmachine @thomasneirynck @mattapperson @tsullivan @markov00 @simianhacker