-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slo): manage slo state #149546
feat(slo): manage slo state #149546
Conversation
dd2e54c
to
9532c1b
Compare
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
a177f04
to
42d6870
Compare
42d6870
to
a94b57b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @kdelemme |
📝 Summary
Resolves #148148
This PR adds two new routes for managing SLOs state: enable and disable.
When enabling an SLO, we set the
enabled
flag to true and start the related transform.When disabling an SLO, we set the
enabled
flag to false and stop the related transform.Nothing is done if the slo is already in the requested state.
🥼 Manual testing
enable slo
enable slo