Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Framework] Add support for wrap prop to FlexGroup #15009

Merged
merged 3 commits into from
Nov 22, 2017
Merged

[UI Framework] Add support for wrap prop to FlexGroup #15009

merged 3 commits into from
Nov 22, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Nov 16, 2017 •
edited
Loading

This also ports elastic/eui#144

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.1.0 v7.0.0 labels Nov 16, 2017
@cjcenizal cjcenizal requested review from snide and nreese November 16, 2017 22:02
nreese
nreese approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for doing this so quickly. This is really going to help input controls

@nreese
Copy link
Contributor

nreese commented Nov 16, 2017

jenkins, test this

@cjcenizal cjcenizal force-pushed the improvement/flex-group-wrap branch 2 times, most recently from 1dbab33 to 67426fa Compare November 18, 2017 17:54
@cjcenizal
Copy link
Contributor Author

cjcenizal commented Nov 20, 2017 •
edited
Loading

Looks like this is failing due to some tests being fixed by #14920.

@cjcenizal cjcenizal force-pushed the improvement/flex-group-wrap branch from 67426fa to 1709792 Compare November 22, 2017 18:23
@cjcenizal cjcenizal added v6.2.0 and removed v6.1.0 labels Nov 22, 2017
@cjcenizal cjcenizal merged commit a2f0867 into elastic:master Nov 22, 2017
@cjcenizal cjcenizal deleted the improvement/flex-group-wrap branch November 22, 2017 19:19
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Nov 22, 2017
@cjcenizal
[UI Framework] Add support for wrap prop to FlexGroup (elastic#15009)
215baa7 
* Migrate KuiFlexItem numeric grow prop from EUI.
* Loop through FlexGroup gutter size modifiers.
* Add wrap prop to FlexGroup.
@cjcenizal cjcenizal mentioned this pull request Nov 22, 2017
Merged
cjcenizal added a commit that referenced this pull request Nov 22, 2017
@cjcenizal
[UI Framework] Add support for wrap prop to FlexGroup (#15009) (#15128)
4e2832d 
* Migrate KuiFlexItem numeric grow prop from EUI.
* Loop through FlexGroup gutter size modifiers.
* Add wrap prop to FlexGroup.
@cjcenizal cjcenizal mentioned this pull request Nov 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.2.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @nreese @snide