Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Render extension component after initializing package policy #150096

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[Fleet] Render extension component after initializing package policy #150096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d5ad5
make isInitialized stateful to prevent out-of-sync validationErrors
orouz Jan 30, 2023
1576af5
Update form.tsx
orouz Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .../fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ export function useOnSubmit({
// Form state
const [formState, setFormState] = useState<PackagePolicyFormState>('VALID');

// Used to render extension components only when package policy is initialized
const [isInitialized, setIsInitialized] = useState<boolean>(false);
// Used to initialize the package policy once
const isInitializedRef = useRef(false);

const [agentPolicy, setAgentPolicy] = useState<AgentPolicy | undefined>();
// New package policy state
const [packagePolicy, setPackagePolicy] = useState<NewPackagePolicy>({
Expand Down Expand Up @@ -210,9 +214,10 @@ export function useOnSubmit({
integrationToEnable
)
);
setIsInitialized(true);
}
init();
}, [packageInfo, agentPolicy, updatePackagePolicy, integrationToEnable]);
}, [packageInfo, agentPolicy, updatePackagePolicy, integrationToEnable, isInitialized]);

const onSaveNavigate = useOnSaveNavigate({
packagePolicy,
Expand Down Expand Up @@ -360,7 +365,7 @@ export function useOnSubmit({
setValidationResults,
hasAgentPolicyError,
setHasAgentPolicyError,
isInitialized: isInitializedRef.current,
isInitialized,
// TODO check
navigateAddAgent,
navigateAddAgentHelp,
Expand Down