-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Route changes announcement #150461
Merged
rshen91
merged 61 commits into
elastic:main
from
rshen91:add-screen-reader-only-app-servs
Feb 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
01c7976
initial commit
rshen91 9f4968a
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 2e133bc
remove change
rshen91 2b3face
wip
rshen91 2832e90
wip
rshen91 0f58ed3
add announcement to createEuiListItem()
rshen91 ee10330
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 5b4c5ac
update i18n
rshen91 eb455b8
i18n new id
rshen91 a9d2da8
focusRegionOnTextChange
rshen91 ac05b30
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine 32f682a
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 98349d6
Merge remote-tracking branch 'origin/add-screen-reader-only-app-servs…
rshen91 1bddf50
add different ids for i18n
rshen91 65dc82c
remove EuiScreenReaderLive from within click evt
rshen91 226e5e0
update for EuiScreenReaderLive before collapsible nav group
rshen91 27c4f97
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 efd2154
clean up announcement to make more sense
rshen91 eabd50a
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 e79301d
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 1e8dc08
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 2753aac
update snapshot test
rshen91 550b2e2
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 7ea735b
update snapshot
rshen91 b487a85
Merge remote-tracking branch 'origin/add-screen-reader-only-app-servs…
rshen91 e418322
remove old code
rshen91 4772719
update
rshen91 3c76b81
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 0c69c18
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 5a01c32
add euiscreenreaderlive to header.tsx
rshen91 c81ecd7
update header snapshot test
rshen91 0b39f1b
Add SR announcements for each page navigation by reacting to breadcru…
cee-chen 5267bc4
Move SR focus region to top of page + add skip to content link
cee-chen eafab86
snapshot updates
cee-chen 54d9ba4
Merge remote-tracking branch 'upstream/main' into add-screen-reader-o…
rshen91 3ff1784
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 2f5d6df
remove skipToContent for tests passing
rshen91 a95b3c5
Merge remote-tracking branch 'origin/add-screen-reader-only-app-servs…
rshen91 8814712
Update packages/core/chrome/core-chrome-browser-internal/src/ui/heade…
rshen91 0cb69ae
code review
rshen91 949e7e4
Merge remote-tracking branch origin/add-screen-reader-only-app-servs …
rshen91 bede3a1
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 ae8da0d
header new lines
rshen91 22701cc
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 b555ae2
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 193be14
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 50eced2
change useEffect hook to useCallback
rshen91 da83124
Merge remote-tracking branch 'origin/add-screen-reader-only-app-servs…
rshen91 44cdb72
update snapshot header test
rshen91 972f4dd
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 9a2e43f
revert changes to hook
rshen91 7f1e9df
Merge remote-tracking branch 'origin/add-screen-reader-only-app-servs…
rshen91 e6bd3a9
Remove `focusRegionOnTextChange`
cee-chen 87797b9
who was definitely not mutating an array in place? me :|
cee-chen 0629d6b
Revert "Remove `focusRegionOnTextChange`" - for science
cee-chen 84243b4
Skip `focusRegionOnTextChange` behavior only for canvas and discover
cee-chen 65304cd
Account for non-Elastic brand page titles
cee-chen 0489ef4
Merge branch 'main' into add-screen-reader-only-app-servs
rshen91 1857a06
add a test
rshen91 0584f62
add more tests
rshen91 52d555c
beef up some testing
rshen91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1Copenut I set
aria-live
toassertive
to make up for the removed focus behavior - not sure if this was the right move or is overly aggressive. Do you mind testing? 🙇There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my testing: it works maybe 75% of the time on Safari+VO but not 100% of the time (for whatever reason, no idea why). Would feel better if we had JAWS and NVDA data.