Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Route changes announcement #150461
[Accessibility] Route changes announcement #150461
Changes from 53 commits
01c7976
9f4968a
2e133bc
2b3face
2832e90
0f58ed3
ee10330
5b4c5ac
eb455b8
a9d2da8
ac05b30
32f682a
98349d6
1bddf50
65dc82c
226e5e0
27c4f97
efd2154
eabd50a
e79301d
1e8dc08
2753aac
550b2e2
7ea735b
b487a85
e418322
4772719
3c76b81
0c69c18
5a01c32
c81ecd7
0b39f1b
5267bc4
eafab86
54d9ba4
3ff1784
2f5d6df
a95b3c5
8814712
0cb69ae
949e7e4
bede3a1
ae8da0d
22701cc
b555ae2
193be14
50eced2
da83124
44cdb72
972f4dd
9a2e43f
7f1e9df
e6bd3a9
87797b9
0629d6b
84243b4
65304cd
0489ef4
1857a06
0584f62
52d555c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1Copenut I set
aria-live
toassertive
to make up for the removed focus behavior - not sure if this was the right move or is overly aggressive. Do you mind testing? 🙇There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my testing: it works maybe 75% of the time on Safari+VO but not 100% of the time (for whatever reason, no idea why). Would feel better if we had JAWS and NVDA data.