Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Fix flaky delete case test #150476

Merged
merged 2 commits into from
Feb 8, 2023
Merged

[Cases] Fix flaky delete case test #150476

merged 2 commits into from
Feb 8, 2023

Conversation

jonathan-buttner
Copy link
Contributor

@jonathan-buttner jonathan-buttner commented Feb 7, 2023 •
edited by kibanamachine
Loading

This PR adds some await to functions that might have been causing flakiness for some of our end to end tests.

Fixes: #145502

Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1878

@jonathan-buttner jonathan-buttner added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.7.0 v8.6.2 labels Feb 7, 2023
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner February 7, 2023 19:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

js-jankisalvi
js-jankisalvi approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally tests which used deleteAllCases utility and all passed 👍

@jonathan-buttner jonathan-buttner merged commit 9bf320f into elastic:main Feb 8, 2023
@jonathan-buttner jonathan-buttner deleted the cases-fix-flaky-delete branch February 8, 2023 14:03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2023
@jonathan-buttner
[Cases] Fix flaky delete case test (elastic#150476)
086a528 
This PR adds some `await` to functions that might have been causing
flakiness for some of our end to end tests.

Fixes: elastic#145502

Flaky test run:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1878

(cherry picked from commit 9bf320f)
@kibanamachine kibanamachine mentioned this pull request Feb 8, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 8, 2023
@kibanamachine @jonathan-buttner
[8.6] [Cases] Fix flaky delete case test (#150476) (#150560)
10ed683 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[Cases] Fix flaky delete case test
(#150476)](#150476)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jonathan
Buttner","email":"56361221+jonathan-buttner@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-08T14:02:56Z","message":"[Cases]
Fix flaky delete case test (#150476)\n\nThis PR adds some `await` to
functions that might have been causing\r\nflakiness for some of our end
to end tests.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145502\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1878","sha":"9bf320f8f6a4552f96ea470679f3835d16f7e31b","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.7.0","v8.6.2"],"number":150476,"url":"https://github.com/elastic/kibana/pull/150476","mergeCommit":{"message":"[Cases]
Fix flaky delete case test (#150476)\n\nThis PR adds some `await` to
functions that might have been causing\r\nflakiness for some of our end
to end tests.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145502\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1878","sha":"9bf320f8f6a4552f96ea470679f3835d16f7e31b"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150476","number":150476,"mergeCommit":{"message":"[Cases]
Fix flaky delete case test (#150476)\n\nThis PR adds some `await` to
functions that might have been causing\r\nflakiness for some of our end
to end tests.\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/145502\r\n\r\nFlaky test
run:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1878","sha":"9bf320f8f6a4552f96ea470679f3835d16f7e31b"}},{"branch":"8.6","label":"v8.6.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.2 v8.7.0
Projects
None yet
Milestone
No milestone
6 participants
@jonathan-buttner @elasticmachine @kibana-ci @kibanamachine @cnasikas @js-jankisalvi