Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] 8.7 Presentation docs #151797

Merged
merged 5 commits into from
Mar 8, 2023
Merged

[DOCS] 8.7 Presentation docs #151797

merged 5 commits into from
Mar 8, 2023

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Feb 21, 2023 •
edited by kibanamachine
Loading

@KOTungseth KOTungseth added Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0 labels Feb 21, 2023
@KOTungseth KOTungseth self-assigned this Feb 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@github-actions
Copy link
Contributor

Documentation preview:

Heenawter
Heenawter reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth mentioning something about #148301 as well? Since this is a pretty significant change on how titles and such are handled, and it adds the ability to give even by-value panels a description 👀

docs/user/dashboard/make-dashboards-interactive.asciidoc Outdated Show resolved Hide resolved
ThomThomson
ThomThomson reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! Something that might be missing though is that @nickpeihl did a lot of user-facing changes for #148301 - which was merged in 8.7.

It looks like Nick actually updated the docs to match #148301 in his PR!

@KOTungseth KOTungseth changed the title [DOCSS] 8.7 Presentation docs [DOCS] 8.7 Presentation docs Mar 8, 2023
Heenawter
Heenawter approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about the aria text for one of the screenshots, but looks great otherwise 🎉

@KOTungseth KOTungseth merged commit e57883f into elastic:main Mar 8, 2023
@KOTungseth KOTungseth deleted the docs/8.7-presentation branch March 8, 2023 22:09
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2023
@KOTungseth
[DOCS] 8.7 Presentation docs (elastic#151797)
e651c7c 
## Summary

- elastic#148331: [Updated
screenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html)
- elastic#146335:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data)
- elastic#146363:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels)
- elastic#144867:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)

(cherry picked from commit e57883f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 8, 2023
@kibanamachine @KOTungseth
[8.7] [DOCS] 8.7 Presentation docs (#151797) (#152967)
e339cb8 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[DOCS] 8.7 Presentation docs
(#151797)](#151797)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2023-03-08T22:09:43Z","message":"[DOCS]
8.7 Presentation docs (#151797)\n\n## Summary\r\n\r\n- #148331:
[Updated\r\nscreenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html)\r\n-
#146335:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data)\r\n-
#146363:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels)\r\n-
#144867:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)","sha":"e57883f3be8772c39cce0b6901a19f3aaf55d2d3","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v8.7.0","v8.8.0"],"number":151797,"url":"https://github.com/elastic/kibana/pull/151797","mergeCommit":{"message":"[DOCS]
8.7 Presentation docs (#151797)\n\n## Summary\r\n\r\n- #148331:
[Updated\r\nscreenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html)\r\n-
#146335:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data)\r\n-
#146363:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels)\r\n-
#144867:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)","sha":"e57883f3be8772c39cce0b6901a19f3aaf55d2d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151797","number":151797,"mergeCommit":{"message":"[DOCS]
8.7 Presentation docs (#151797)\n\n## Summary\r\n\r\n- #148331:
[Updated\r\nscreenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html)\r\n-
#146335:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data)\r\n-
#146363:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels)\r\n-
#144867:\r\n[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)","sha":"e57883f3be8772c39cce0b6901a19f3aaf55d2d3"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@KOTungseth @bmorelli25
[DOCS] 8.7 Presentation docs (elastic#151797)
5b847e7 
## Summary

- elastic#148331: [Updated
screenshots](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html)
- elastic#146335:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#search-or-filter-your-data)
- elastic#146363:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/dashboard.html#edit-panels)
- elastic#144867:
[Docs](https://kibana_151797.docs-preview.app.elstc.co/guide/en/kibana/master/add-controls.html#edit-controls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson left review comments

@Heenawter Heenawter Heenawter approved these changes

Assignees

@KOTungseth KOTungseth

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KOTungseth @elasticmachine @kibanamachine @Heenawter @ThomThomson