[Cloud Posture] Ensure package policy namespace is always set to default #152168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanSh
approved these changes
Feb 26, 2023
orouz
force-pushed
the
csp_fleet_namespace
branch
from
7e2b1e0 to
f6a462d
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
orouz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
orouz
added a commit
to orouz/kibana
that referenced
this pull request
Feb 27, 2023
orouz
added a commit
that referenced
this pull request
Feb 27, 2023
…o default (#152168) (#152175) # Backport This will backport the following commits from `main` to `8.7`: - [[Cloud Posture] Ensure package policy namespace is always set to default (#152168)](#152168) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Or Ouziel","email":"or.ouziel@elastic.co"},"sourceCommit":{"committedDate":"2023-02-27T05:26:14Z","message":"[Cloud Posture] Ensure package policy namespace is always set to default (#152168)","sha":"5d3d75fe83aa662d3b7d1acad282ab7a55fbce06","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","v8.7.0","v8.8.0"],"number":152168,"url":"https://github.com/elastic/kibana/pull/152168","mergeCommit":{"message":"[Cloud Posture] Ensure package policy namespace is always set to default (#152168)","sha":"5d3d75fe83aa662d3b7d1acad282ab7a55fbce06"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152168","number":152168,"mergeCommit":{"message":"[Cloud Posture] Ensure package policy namespace is always set to default (#152168)","sha":"5d3d75fe83aa662d3b7d1acad282ab7a55fbce06"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
once #151886 is merged, changes to agent policy will update the package policy id and also the namespace. in our case, we only support the
defaultnamespace (IIRC - to prevent confusion with k8s namespaces)so this PR adds an effect to ensure the namespace is always set to default