Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing scss override files for anomaly detection jobs #152240

Merged
merged 12 commits into from
Mar 2, 2023
Merged

[ML] Removing scss override files for anomaly detection jobs #152240

merged 12 commits into from
Mar 2, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 27, 2023 •
edited by peteharverson
Loading

Removes the scss files which were being used to override various eui styles or add styles to custom components.
Affect the anomaly detection jobs list and wizards.

This is not an in-depth refactor of our styles, and so some overrides are still necessary in order to retain an identical UI, in these cases the style overrides have been moved to inline emotion css.

Part of #140695

@jgowdyelastic jgowdyelastic added chore non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Feb 27, 2023
@jgowdyelastic jgowdyelastic self-assigned this Feb 27, 2023
@jgowdyelastic jgowdyelastic requested review from a team as code owners February 27, 2023 15:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic commented Feb 27, 2023
View reviewed changes
x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details_pane.tsx
@@ -0,0 +1,139 @@
/*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored into typescript to ease the use of useEuiTheme

darnautov
darnautov reviewed Feb 28, 2023
View reviewed changes
x-pack/plugins/ml/public/application/components/loading_indicator/loading_indicator.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/components/stats_bar/stats_bar.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details.js Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details_pane.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details_pane.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details_pane.tsx Outdated Show resolved Hide resolved
darnautov
darnautov approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

peteharverson
peteharverson approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (Firefox) and the relevant pages / components LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / dashboard dashboard maps by value editing a map and adding to map library does not update the panel when only saving to library

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB -12.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 428 430 +2

Total ESLint disabled count

id before after diff
securitySolution 506 508 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 0d04fd7 into elastic:main Mar 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 2, 2023
@jgowdyelastic jgowdyelastic deleted the removing-scss-override-files-for-ad-jobs branch March 2, 2023 09:46
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@jgowdyelastic @bmorelli25
[ML] Removing scss override files for anomaly detection jobs (elastic…
ed3e5c1 
…#152240)

Removes the scss files which were being used to override various eui
styles or add styles to custom components.
Affect the anomaly detection jobs list and wizards.

This is not an in-depth refactor of our styles, and so some overrides
are still necessary in order to retain an identical UI, in these cases
the style overrides have been moved to inline emotion `css`.

Part of elastic#140695
@peteharverson peteharverson mentioned this pull request Jun 19, 2023
Open
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

@mdefazio mdefazio mdefazio approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting chore Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgowdyelastic @elasticmachine @kibana-ci @mdefazio @darnautov @peteharverson @kibanamachine