-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add support for dynamic_namespace and dynamic_dataset #154732
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Show resolved
Hide resolved
ad6c4e8
to
750deb6
Compare
Pinging @elastic/fleet (Team:Fleet) |
Is the following assumption correct:
|
@ruflin Yes, that should be right. I can update the integration test to include a metrics data stream as well if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but let's resolve the open conversation around moving this option to a higher level in the package manifest if needed.
...k/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.test.ts
Show resolved
Hide resolved
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Closes #134971
This adds support for data_streams in packages to specify
elasticsearch.dynamic_dataset
andelasticsearch.dynamic_namespace
in order to get wildcard privileges on the API key that is granted by Fleet Server to the agent running this integration. This is necessary for integrations that want to support centralized document routing via ingest pipelines.I opted to keep this simple and not de-dupe the overlap between the wildcard privileges granted in one data stream with the other privileges for other data streams. Elasticsearch will already handle this correctly when defining the API key role definition (I verified manually).
A new integration test has been added with a test package that defines these options. This is necessary because there are many moving parts to the code that needed to change to support this.
Checklist
Delete any items that are not applicable to this PR.
For maintainers