Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreserveCrossAppState introduced flakiness in the tests - need to wait for page loading to finish #15495

Merged
merged 1 commit into from
Dec 8, 2017
Merged

PreserveCrossAppState introduced flakiness in the tests - need to wait for page loading to finish #15495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/functional/page_objects/dashboard_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
async preserveCrossAppState() {
const url = await remote.getCurrentUrl();
await remote.get(url, false);
await PageObjects.header.waitUntilLoadingHasFinished();
}

async clickEditVisualization() {
Expand Down