Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dot-kibana-split] Make indices.getMapping() resilient to intermitent failures #155752

Conversation

gsoldevila
Copy link
Contributor

When the migrator logic kicks in at startup, it checks the indexTypesMap stored in the main SO index (aka .kibana).
It does so by using esClient.indices.getMapping() method.

Should this method fail due to temporary ES failures (i.e. retriable errors), we want this logic to retry forever, rather than failing and bringing the whole Kibana down.

@gsoldevila gsoldevila added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:Migrations v8.8.0 labels Apr 25, 2023
@gsoldevila gsoldevila requested a review from a team as a code owner April 25, 2023 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@gsoldevila gsoldevila enabled auto-merge (squash) April 25, 2023 16:53
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 396 399 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 476 479 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsoldevila We need to tell QA how to test this change and others that are follow ups to the 'main' PR where we split the indices.
They're going to see a bunch of PR's related to migrations and won't have enough background info to see what they should focus on.
Either add a "How to test this" here or in a detailed document to share with them.
Code changes LGTM.

@gsoldevila gsoldevila merged commit 283f285 into elastic:main Apr 25, 2023
@gsoldevila
Copy link
Contributor Author

Either add a "How to test this" here or in a detailed document to share with them.

That's a good point. I'll liaise with Rudolf to help me shape an appropriate document for QA.

@rudolf rudolf added the Epic:ScaleMigrations Scale upgrade migrations to millions of saved objects label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Epic:ScaleMigrations Scale upgrade migrations to millions of saved objects Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants