Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset state of pipeline flyout on close or completion #155760

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Reset state of pipeline flyout on close or completion #155760

merged 2 commits into from
Apr 26, 2023

Conversation

seanstory
Copy link
Member

Summary

Fixes a bug where adding a second pipeline would pop you into the last page of the previously added pipeline flyout.

can't create new pipeline

For maintainers

@seanstory seanstory added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.8.0 labels Apr 25, 2023
@seanstory seanstory requested review from a team and demjened April 25, 2023 18:47
sloanelybutsurely
sloanelybutsurely approved these changes Apr 25, 2023
View reviewed changes
Copy link

@sloanelybutsurely sloanelybutsurely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔

demjened
demjened approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@demjened
Copy link
Contributor

@seanstory The type failure is unrelated to this change. This PR fixed it, so once you rebase or merge from main, CI will pass.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB +256.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 397 400 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 477 480 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@seanstory seanstory merged commit c0033a1 into elastic:main Apr 26, 2023
@seanstory seanstory deleted the seanstory/4333-fix-multiple-pipeline-flow branch April 26, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demjened demjened demjened approved these changes

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanstory @demjened @kibana-ci @sloanelybutsurely