Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Improve testing instructions in README #156993

Merged
merged 4 commits into from
May 8, 2023
Merged

[Fleet] Improve testing instructions in README #156993

merged 4 commits into from
May 8, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 8, 2023

Summary

Related to #145988

Improve testing instructions in Fleet README

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels May 8, 2023
@nchaulet nchaulet requested a review from a team as a code owner May 8, 2023 13:19
@nchaulet nchaulet self-assigned this May 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet force-pushed the feature-improve-testing-instructions branch from 2055b8d to 1f37f20 Compare May 8, 2023 13:21
@nchaulet
Copy link
Member Author

nchaulet commented May 8, 2023

@elasticmachine merge upstream

criamico
criamico approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo to fix but LGTM overall. Thanks for this! 🚢

x-pack/plugins/fleet/README.md Outdated
node scripts/jest_integration.js x-pack/plugins/fleet/server/integration_tests/<YOUR_TEST_FILE>
```

You could also use node debbuger to inspect ES indices (add the `debbuger` directive in your test)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo in two places here: "debbuger" instead of "debugger"

nchaulet added 2 commits May 8, 2023 09:46
@nchaulet nchaulet enabled auto-merge (squash) May 8, 2023 14:32
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / endpoint Response Actions Responder from timeline should show Responder from alert in a timeline

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit a1b961f into elastic:main May 8, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nchaulet @elasticmachine @apmmachine @kibana-ci @criamico @kibanamachine