Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slo): simplify error budget calculations #158941

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jun 2, 2023

Resolves #158942

📝 Summary

Reason for change: https://elastic.slack.com/archives/C044PV8EJ4X/p1685717478850789

This PR updates the error budget calculation method for SLO setup with an occurrences budgeting method and calendar aligned time window, so we don't try to estimate the total number of events that will occur in the period.
This is important in order to support Composite SLO.

@kdelemme kdelemme added v8.9.0 release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Jun 2, 2023
@kdelemme kdelemme self-assigned this Jun 2, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme requested a review from simianhacker June 2, 2023 15:17
@kdelemme kdelemme marked this pull request as ready for review June 2, 2023 15:45
@kdelemme kdelemme requested a review from a team as a code owner June 2, 2023 15:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme force-pushed the simplify-slo-math branch from 6aba5c5 to 3238021 Compare June 2, 2023 18:00
@kdelemme kdelemme force-pushed the simplify-slo-math branch from 3238021 to 8fcd713 Compare June 2, 2023 18:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

  • 💚 Build #132177 succeeded 6aba5c58b5d456ba2373d19b21c43f778ff30654

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 4af1bd5 into elastic:main Jun 5, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 5, 2023
@kdelemme kdelemme deleted the simplify-slo-math branch June 5, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Update error budget calculation methods
6 participants