Attempt to fix flaky tests after split migration #159002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: |
rudolf
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
Although this fixes the flaky tests it breaks many other. Gerard is working on a different approach that we think might be better able to solve this race condition. |
jeramysoucy
added a commit
to jeramysoucy/kibana
that referenced
this pull request
Jun 13, 2023
…ble_action (elastic#159039) ## Summary Skips several tests failing with the `no_shard_available_action_exception`. Also adds comments noting the related test failure issues and the [master issue being tracked](elastic#158918). See issue elastic#158918 and PR elastic#159002. (cherry picked from commit 63bd0ba) # Conflicts: # x-pack/test/saved_object_api_integration/spaces_only/apis/resolve_import_errors.ts # x-pack/test/spaces_api_integration/spaces_only/apis/get.ts # x-pack/test/spaces_api_integration/spaces_only/apis/update.ts
jeramysoucy
added a commit
that referenced
this pull request
Jun 13, 2023
…available_action (#159039) (#159546) # Backport This will backport the following commits from `main` to `8.8`: - [[Failing Tests] Skips and comments tests failing with no_shard_available_action (#159039)](#159039) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-06-06T07:11:22Z","message":"[Failing Tests] Skips and comments tests failing with no_shard_available_action (#159039)\n\n## Summary\r\n\r\nSkips several tests failing with the\r\n`no_shard_available_action_exception`. Also adds comments noting the\r\nrelated test failure issues and the [master issue being\r\ntracked](https://github.com/elastic/kibana/issues/158918).\r\n\r\nSee issue #158918 and PR #159002.","sha":"63bd0ba9f9cec244cac38affc2bc572ad5f6a6aa","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Saved Objects","Feature:Security/Spaces","skipped-test","release_note:skip","backport:prev-minor","v8.9.0"],"number":159039,"url":"https://github.com/elastic/kibana/pull/159039","mergeCommit":{"message":"[Failing Tests] Skips and comments tests failing with no_shard_available_action (#159039)\n\n## Summary\r\n\r\nSkips several tests failing with the\r\n`no_shard_available_action_exception`. Also adds comments noting the\r\nrelated test failure issues and the [master issue being\r\ntracked](https://github.com/elastic/kibana/issues/158918).\r\n\r\nSee issue #158918 and PR #159002.","sha":"63bd0ba9f9cec244cac38affc2bc572ad5f6a6aa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159039","number":159039,"mergeCommit":{"message":"[Failing Tests] Skips and comments tests failing with no_shard_available_action (#159039)\n\n## Summary\r\n\r\nSkips several tests failing with the\r\n`no_shard_available_action_exception`. Also adds comments noting the\r\nrelated test failure issues and the [master issue being\r\ntracked](https://github.com/elastic/kibana/issues/158918).\r\n\r\nSee issue #158918 and PR #159002.","sha":"63bd0ba9f9cec244cac38affc2bc572ad5f6a6aa"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses root cause of #158918
In this PR I just re-enabled two of the skipped suites. I'll keep the parent issue open after merging this one. If these two enabled suites are stable, I'll re-enable the other ones too.
Flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2348, no failures after 100 runs ✅
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers