-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rel="noopener noreferrer" to all target=_blank #15949
Conversation
You will need to update the snapshots for the tests for this to pass, by running Also I wonder, whether we could solve this in |
@timroes Yes I agree that we should do this at the component level, since it's a security concern. @nyurik Would you mind making this change to the relevant components so that all links with |
@cjcenizal I'm not very familiar with that code - could you give me a link to where this would be implemented? |
@nyurik Sure, it's here: https://github.com/elastic/kibana/blob/master/ui_framework/src/components/button/button.js#L123 We'll need to add the |
@nyurik I'm about to start work on this. Unless you've already started? I don't want to step on your toes. 😄 |
@cjcenizal sorry, got sidetracked with some other projects :( I need to get a bunch of things ready for EON. |
No worries! I'll bang this out. Mind if I tag you as a reviewer? |
@cjcenizal I saw your patch, thx! Add me any time :) |
Should I abandon this patch? |
@nyurik Yes please close this. I think that because the KUI Framework has been deprecated, we don't need to worry about changing it as I suggested in #15949 (comment). I did a search and it looks like we're not using this component in conjunction with |
I'm not sure the rel attribute is needed for these cases, so to review, creating this PR.
This was mentioned to me at #15014 (comment)