[EBT] Add page url to browser-side context #159916
Conversation
pgayvallet
added
Feature:Telemetry
release_note:skip
pgayvallet
changed the title
pgayvallet
changed the title
| await navigate('/app/app1/bar?hello=dolly'); | ||
| await flushPromises(); | ||
| await navigate('/app/app2#/foo'); | ||
| await flushPromises(); | ||
|
|
There was a problem hiding this comment.
Q: would it work when navigating inside the same app?
There was a problem hiding this comment.
Yeah it does, but I can add a test to ensure that
| const location$ = getLocationObservable(window.location, this.history); | ||
| registerAnalyticsContextProvider({ | ||
| analytics, | ||
| location$, | ||
| }); |
There was a problem hiding this comment.
The actual registration
| const locationToUrl = (location: Location) => { | ||
| return `${location.pathname}${location.hash}`; | ||
| }; |
There was a problem hiding this comment.
Converting Location to our actual url: using pathname + hash
| history.listen((location) => { | ||
| subject.next(locationToUrl(location)); | ||
| }); | ||
| return subject.pipe( | ||
| startWith(locationToUrl(initialLocation)), | ||
| distinctUntilChanged(), | ||
| shareReplay(1) | ||
| ); |
There was a problem hiding this comment.
Emit with initial page's location + on each history change. Using distinctUntilChanged to avoid emitting multiple time for the exact same url
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Part of #149249
Add a new EBT context providing the
page_urlfield to events.page_urlis based on the current url'spathnameandhashexclusively (no domain, port, query param...)