-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Add performance journey for transform wizard source index loading. #160837
[ML] Transforms: Add performance journey for transform wizard source index loading. #160837
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job adding in our first performance journey! LGTM
const span = this.currentTransaction.startSpan(name, type ?? null); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I need to run a few pipelines to make sure we are able to extract APM transactions for scalability test simulation
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
const loadIndexDataDuration = window.performance.now() - loadIndexDataStartTime.current; | ||
|
||
// Set this to undefined so reporting the metric gets triggered only once. | ||
loadIndexDataStartTime.current = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one! Having a single value for each metric per run seems the best way to go at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dima commented he is going to validate the apm transaction thing.
The rest lgtm on the operations side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
Summary
Part of #160712.
Add a performance journey for transform wizard source index loading.
Journey showing up in APM:
Journey showing up in Performance Metrics:
Checklist