[Cases] Create and update case API guardrails for title, description, category, tags

[js-jankisalvi]

Connected to #146945

Summary

Description	Limit	Done?	Documented?
Total number of description characters	30.000	✅	Yes
Total number of tags per case	200	✅	Yes
Total number of characters per tag	256	✅	Yes

• Used schema validation.
• Updated documentation.
• Added jest and integration tests.

Note: In this PR, maximum length of title (160 characters) and maximum length of category field (50 characters) validations are also moved to schema validation.

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

Release notes

The Create Case and Update Case APIs put the following limits:

• Total number of characters per title: 160
• Total number of characters per description: 30K
• Total number of tags per case: 200
• Total number of characters per tag: 256
• Total number of characters per category: 50

[elasticmachine]

Pinging @elastic/response-ops (Team:ResponseOps)

[elasticmachine]

Pinging @elastic/response-ops-cases (Feature:Cases)

[adcoelho]

I wonder if we should throw for scenarios like this.

Calling patch without any params is allowed but we might as well notify the caller that something is probably wrong. @cnasikas ?

[cnasikas]

We should let users put an empty array of tags as is the only way to remove all tags from a case. Same when creating a case.

[jonathan-buttner]

Great work, left a few questions.

[jonathan-buttner]

Hmm do we want spaces to count as valid characters towards the min and max?

[js-jankisalvi]

I am assuming here that start and end of string spaces are unnecessary and should be removed before checking the length. But I am open if we want to keep it.

[cnasikas]

I think it all depends on what we persist in ES. If we persist the spaces (which I think we are), then we should not trim. Or the other way around, if we think that we should trim (probably yes because we should not allow a title of only spaces), then we should trim before persisting it to ES. I lean towards trimming it to not allow titles with only empty spaces.

[js-jankisalvi]

It makes sense to me to trim for validation as well as before persisting to ES.

[cnasikas]

Ok, let's leave the trimming but let's be consistent (not on this PR). In the UI for example no error is being shown in the case view page when you add an empty string to the title. In the backend, we do not trim before saving.

[cnasikas]

As we trim a lot in this function I think it is better if we put it on a variable. For example, const trimedString = s.trim()

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: dfcb2be

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
cases	143.4KB	144.1KB	+730.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	413	417	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	492	496	+4
total			+6

History

• 💚 Build #139393 succeeded 719d163
• 💚 Build #139314 succeeded 5b2a325
• 💚 Build #139204 succeeded c865f86
• 💚 Build #139062 succeeded be13b94

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

[lcawl]

OAS changes LGTM, thanks!