-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Disable certain actions for serverless #161528
[Index Management] Disable certain actions for serverless #161528
Conversation
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for serverless config change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes @sabarasaba! I tested locally and code changes overall look good to me. I only saw one place where the logic might need to be changed. Let me know what you think.
...pplication/sections/home/index_list/index_actions_context_menu/index_actions_context_menu.js
Show resolved
Hide resolved
… show it when actions are enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comment! LGTM 👍
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to test/plugin_functional/test_suites/core_plugins/rendering.ts
LGTM
## Summary Follow up to #161528 This PR leverages the [schema.contextRef('serverless') check](https://www.elastic.co/guide/en/kibana/master/configuration-service.html#validating-your-configuration-based-on-context-references) to prevent the config `enableIndexActions` from leaking to self-managed. ### Screenshots Stateful (no changes), index actions enabled <img width="916" alt="Screenshot 2023-08-09 at 12 15 31" src="https://github.com/elastic/kibana/assets/6585477/527ce600-8758-44b4-bd41-c93723254646"> Serverless (no changes), index actions disabled <img width="622" alt="Screenshot 2023-08-09 at 12 09 45" src="https://github.com/elastic/kibana/assets/6585477/80190375-6cea-445d-8a75-3b354a447e9d">
Fixes #157945
Summary
In serverless, certain index actions will be blocked by Elasticsearch. This PR creates a new config that allows us to configure their visibility to the user and disables it for serverless. The disabled actions are:
How to test
yarn es snapshot --license=trial
and serverless search solution withyarn serverless-es
Console
and create a simple indexPUT test/_doc/1 { message: "hello" }
Index Management
app (Navigation doesnt include a link to it yet but can can access it by url directly with/app/management/data/index_management/indices
) and make sure that the actions are limited to whats allowed.Screenshots
// Serverless
// On-prem