Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR - esArchiver] Update saved_object_api_integration archive to NOT delete SO indices #161852

Merged
merged 2 commits into from
Jul 17, 2023
Merged

[FTR - esArchiver] Update saved_object_api_integration archive to NOT delete SO indices #161852

merged 2 commits into from
Jul 17, 2023

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Jul 13, 2023 •
edited
Loading

Summary

Part of #161882

Updates the x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces archive:

  • deleting mappings.json
  • updating documents in data.json

This way, esArchiver will not delete SO indices and recreate them, eliminating the odds of the related tests being flaky.

CC @jeramysoucy @dmlemeshko

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting FTR v8.10.0 labels Jul 13, 2023
@gsoldevila gsoldevila changed the title [FTR - esArchiver] Update archive to NOT delete SO indices [FTR - esArchiver] Update saved_object_api_integration archive to NOT delete SO indices Jul 13, 2023
@gsoldevila gsoldevila self-assigned this Jul 13, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gsoldevila

@gsoldevila gsoldevila mentioned this pull request Jul 13, 2023
Open
@gsoldevila gsoldevila marked this pull request as ready for review July 14, 2023 10:59
@gsoldevila gsoldevila requested a review from a team as a code owner July 14, 2023 10:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

jeramysoucy
jeramysoucy approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsoldevila gsoldevila merged commit 94a495f into elastic:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

@gsoldevila gsoldevila

Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! technical debt Improvement of the software architecture and operational architecture v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsoldevila @kibana-ci @elasticmachine @pgayvallet @jeramysoucy