[esArchiver] Do not perform SO migration on cleanup #163302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
gsoldevila
added
the
bug
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Aug 10, 2023
davismcphee
approved these changes
Aug 10, 2023
|
@gsoldevila, can we run the Flaky Test runner to confirm the flakiness is gone? |
Running on https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850 |
pgayvallet
approved these changes
Aug 30, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
I investigated the flakiness of the last CI build, will create a separate PR for it. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 1, 2023
## Summary Attempt at fixing elastic#127545 The failing tests use `esArchiver` to cleanup Saved Object indices between tests. Strangely, the cleanup method calls the migration logic to update the SO indices. In this particular source of flakiness, a test fails during the migration (problem is tracked by elastic#163289). Performing a migration as part of the cleanup does not make too much sense (at least in this test suite), so the goal of this PR is to simplify the cleanup operation, getting rid of the call to `migrateSavedObjectIndices`. 50 runs flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850 ✅ (cherry picked from commit f8303ec)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2023
…165451) # Backport This will backport the following commits from `main` to `8.10`: - [[esArchiver] Do not perform SO migration on cleanup (#163302)](#163302) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-09-01T10:41:20Z","message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","Team:Operations","release_note:skip","test-failure-flaky","backport:all-open","v8.11.0"],"number":163302,"url":"https://github.com/elastic/kibana/pull/163302","mergeCommit":{"message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163302","number":163302,"mergeCommit":{"message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Sep 4, 2023
## Summary Attempt at fixing elastic#127545 The failing tests use `esArchiver` to cleanup Saved Object indices between tests. Strangely, the cleanup method calls the migration logic to update the SO indices. In this particular source of flakiness, a test fails during the migration (problem is tracked by elastic#163289). Performing a migration as part of the cleanup does not make too much sense (at least in this test suite), so the goal of this PR is to simplify the cleanup operation, getting rid of the call to `migrateSavedObjectIndices`. 50 runs flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850 ✅ (cherry picked from commit f8303ec) # Conflicts: # packages/kbn-es-archiver/src/actions/empty_kibana_index.ts # test/examples/search/warnings.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
that referenced
this pull request
Sep 25, 2023
…165566) # Backport This will backport the following commits from `main` to `7.17`: - [[esArchiver] Do not perform SO migration on cleanup (#163302)](#163302) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-09-01T10:41:20Z","message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","Team:Operations","release_note:skip","test-failure-flaky","backport:all-open","v8.10.0","v8.11.0"],"number":163302,"url":"https://github.com/elastic/kibana/pull/163302","mergeCommit":{"message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/165451","number":165451,"state":"MERGED","mergeCommit":{"sha":"8ea7cee5003c3bfb550da9ab1fab8e9bfe820250","message":"[8.10] [esArchiver] Do not perform SO migration on cleanup (#163302) (#165451)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.10`:\n- [[esArchiver] Do not perform SO migration on cleanup\n(#163302)](https://github.com/elastic/kibana/pull/163302)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Gerard\nSoldevila\",\"email\":\"gerard.soldevila@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-09-01T10:41:20Z\",\"message\":\"[esArchiver]\nDo not perform SO migration on cleanup (#163302)\\n\\n##\nSummary\\r\\n\\r\\nAttempt at fixing\nhttps://github.com//issues/127545\\r\\n\\r\\nThe failing tests\nuse `esArchiver` to cleanup Saved Object indices\\r\\nbetween\ntests.\\r\\nStrangely, the cleanup method calls the migration logic to\nupdate the SO\\r\\nindices.\\r\\n\\r\\nIn this particular source of flakiness,\na test fails during the\\r\\nmigration (problem is tracked\nby\\r\\nhttps://github.com//issues/163289).\\r\\n\\r\\nPerforming\na migration as part of the cleanup does not make too much\\r\\nsense (at\nleast in this test suite), so the goal of this PR is to\\r\\nsimplify the\ncleanup operation, getting rid of the call\nto\\r\\n`migrateSavedObjectIndices`.\\r\\n\\r\\n50 runs flaky test\nrunner\\r\\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\\r\\n✅\",\"sha\":\"f8303ec7cf57aa8787331ada397dfa853de969c9\",\"branchLabelMapping\":{\"^v8.11.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"Team:Core\",\"Team:Operations\",\"release_note:skip\",\"test-failure-flaky\",\"backport:all-open\",\"v8.11.0\"],\"number\":163302,\"url\":\"https://github.com/elastic/kibana/pull/163302\",\"mergeCommit\":{\"message\":\"[esArchiver]\nDo not perform SO migration on cleanup (#163302)\\n\\n##\nSummary\\r\\n\\r\\nAttempt at fixing\nhttps://github.com//issues/127545\\r\\n\\r\\nThe failing tests\nuse `esArchiver` to cleanup Saved Object indices\\r\\nbetween\ntests.\\r\\nStrangely, the cleanup method calls the migration logic to\nupdate the SO\\r\\nindices.\\r\\n\\r\\nIn this particular source of flakiness,\na test fails during the\\r\\nmigration (problem is tracked\nby\\r\\nhttps://github.com//issues/163289).\\r\\n\\r\\nPerforming\na migration as part of the cleanup does not make too much\\r\\nsense (at\nleast in this test suite), so the goal of this PR is to\\r\\nsimplify the\ncleanup operation, getting rid of the call\nto\\r\\n`migrateSavedObjectIndices`.\\r\\n\\r\\n50 runs flaky test\nrunner\\r\\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\\r\\n✅\",\"sha\":\"f8303ec7cf57aa8787331ada397dfa853de969c9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.11.0\",\"labelRegex\":\"^v8.11.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/163302\",\"number\":163302,\"mergeCommit\":{\"message\":\"[esArchiver]\nDo not perform SO migration on cleanup (#163302)\\n\\n##\nSummary\\r\\n\\r\\nAttempt at fixing\nhttps://github.com//issues/127545\\r\\n\\r\\nThe failing tests\nuse `esArchiver` to cleanup Saved Object indices\\r\\nbetween\ntests.\\r\\nStrangely, the cleanup method calls the migration logic to\nupdate the SO\\r\\nindices.\\r\\n\\r\\nIn this particular source of flakiness,\na test fails during the\\r\\nmigration (problem is tracked\nby\\r\\nhttps://github.com//issues/163289).\\r\\n\\r\\nPerforming\na migration as part of the cleanup does not make too much\\r\\nsense (at\nleast in this test suite), so the goal of this PR is to\\r\\nsimplify the\ncleanup operation, getting rid of the call\nto\\r\\n`migrateSavedObjectIndices`.\\r\\n\\r\\n50 runs flaky test\nrunner\\r\\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\\r\\n✅\",\"sha\":\"f8303ec7cf57aa8787331ada397dfa853de969c9\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>"}},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163302","number":163302,"mergeCommit":{"message":"[esArchiver] Do not perform SO migration on cleanup (#163302)\n\n## Summary\r\n\r\nAttempt at fixing https://github.com/elastic/kibana/issues/127545\r\n\r\nThe failing tests use `esArchiver` to cleanup Saved Object indices\r\nbetween tests.\r\nStrangely, the cleanup method calls the migration logic to update the SO\r\nindices.\r\n\r\nIn this particular source of flakiness, a test fails during the\r\nmigration (problem is tracked by\r\nhttps://github.com//issues/163289).\r\n\r\nPerforming a migration as part of the cleanup does not make too much\r\nsense (at least in this test suite), so the goal of this PR is to\r\nsimplify the cleanup operation, getting rid of the call to\r\n`migrateSavedObjectIndices`.\r\n\r\n50 runs flaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850\r\n✅","sha":"f8303ec7cf57aa8787331ada397dfa853de969c9"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt at fixing #127545
The failing tests use
esArchiverto cleanup Saved Object indices between tests.Strangely, the cleanup method calls the migration logic to update the SO indices.
In this particular source of flakiness, a test fails during the migration (problem is tracked by #163289).
Performing a migration as part of the cleanup does not make too much sense (at least in this test suite), so the goal of this PR is to simplify the cleanup operation, getting rid of the call to
migrateSavedObjectIndices.50 runs flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2850 ✅