Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] expandable flyout - add isolate host panel #165933

Merged
merged 4 commits into from
Sep 7, 2023
Merged

[Security Solution] expandable flyout - add isolate host panel #165933

merged 4 commits into from
Sep 7, 2023

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Sep 7, 2023 •
edited by kibanamachine
Loading

Summary

This new expandable flyout is going GA in 8.10. One feature isn't working: the isolate host/'release hostfrom thetake action` button in the right section footer. The code was added in this PR but isolate host testing must have been overlooked.

This PR adds the functionality to the new expandable flyout, by creating a new panel, displayed similarly to the right panel is today.

Screen.Recording.2023-09-07.at.9.58.27.AM.mov

#165933

How to test manually

  1. Run ES and Kibana locally
  2. When Kibana is up and running, run node x-pack/plugins/security_solution/scripts/endpoint/endpoint_agent_emulator.js --asSuperuser and load fake endpoints.
  3. After endpoints are loaded via the script above, visit the Alerts page /app/security/alerts. If alerts are not visible, click on Manage Rules and toggle Endpoint Security and visit Alerts page again. You should see alerts from the fake agents.
  4. Click on the View details action item under Actions column to show the details flyout.
  5. Click on Take action button on the flyout footer and then click on Isolate host (if the host is not isolated) or Release host (if the host is isolated). This should show the corresponding isolate/releae flyout where you should be able to add a comment and submit the action.

TODO

  • verify logic
  • add unit tests
  • add Cypress tests

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner September 7, 2023 07:59
ashokaditya
ashokaditya approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @PhilippeOberti. I tested it out manually and works as expected! 🚢 it!

@ashokaditya ashokaditya enabled auto-merge (squash) September 7, 2023 12:03
@PhilippeOberti PhilippeOberti force-pushed the expandable-flyout-isolate-host branch from 9f3c86c to 9ae3540 Compare September 7, 2023 13:25
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 7, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Cypress Tests #1 / Cases Creates a new case with timeline and opens the timeline Creates a new case with timeline and opens the timeline
  • [job] [logs] Serverless Security Explore Cypress Tests #2 / Overview Page "before all" hook for "Host stats render with correct values" "before all" hook for "Host stats render with correct values"
  • [job] [logs] Serverless Security Explore Cypress Tests #2 / Overview Page "before each" hook for "Host stats render with correct values" "before each" hook for "Host stats render with correct values"
  • [job] [logs] Serverless Security Cypress Tests #1 / Prebuilt rules Alerts rules, prebuilt rules "before all" hook for "Loads prebuilt rules" "before all" hook for "Loads prebuilt rules"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Application is shown in the global search

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4504 4510 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB +2.8KB

History

  • 💔 Build #157179 failed 9f3c86cdfd50008be63ea9901cde11d64af6a253
  • 💔 Build #157143 failed b8786a07d640185f35c4228bae68afe5c78e6c6f
  • 💔 Build #157071 failed 17544037288029d472e1e5ed8b37e6fef04fb66d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kevinlog
kevinlog approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it out and tried it -

Release and Isolate flyouts work and create the actions as expected.

Release:
image

Isolate:
image

@ashokaditya ashokaditya merged commit ed48990 into elastic:main Sep 7, 2023
@PhilippeOberti PhilippeOberti deleted the expandable-flyout-isolate-host branch September 7, 2023 14:50
@kibanamachine kibanamachine mentioned this pull request Sep 7, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2023
@PhilippeOberti
[Security Solution] expandable flyout - add isolate host panel (elast…
b942744 
…ic#165933)

## Summary

This new expandable flyout is going GA in `8.10`. One feature isn't
working: the `isolate host` from the `take action` button in the right
section footer. The code was added in this
[PR](elastic#153903) but isolate host
testing must have been overlooked.

This PR adds the functionality to the new expandable flyout, by creating
a new panel, displayed similarly to the right panel is today.

https://github.com/elastic/kibana/assets/17276605/abd99323-616b-4474-a21c-29ce3c56dd1a

elastic#165933

### TODO

- [ ] verify logic
- [ ] add unit tests
- [ ] add Cypress tests

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Ashokaditya <ashokaditya@elastic.co>
(cherry picked from commit ed48990)
kibanamachine added a commit that referenced this pull request Sep 7, 2023
@kibanamachine @PhilippeOberti
[8.10] [Security Solution] expandable flyout - add isolate host panel (…
824bcbf 
…#165933) (#165984)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] expandable flyout - add isolate host panel
(#165933)](#165933)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2023-09-07T14:49:10Z","message":"[Security
Solution] expandable flyout - add isolate host panel (#165933)\n\n##
Summary\r\n\r\nThis new expandable flyout is going GA in `8.10`. One
feature isn't\r\nworking: the `isolate host` from the `take action`
button in the right\r\nsection footer. The code was added in
this\r\n[PR](#153903) but isolate
host\r\ntesting must have been overlooked.\r\n\r\nThis PR adds the
functionality to the new expandable flyout, by creating\r\na new panel,
displayed similarly to the right panel is
today.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17276605/abd99323-616b-4474-a21c-29ce3c56dd1a\r\n\r\nhttps://github.com//pull/165933\r\n\r\n###
TODO\r\n\r\n- [ ] verify logic\r\n- [ ] add unit tests\r\n- [ ] add
Cypress tests\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Ashokaditya
<ashokaditya@elastic.co>","sha":"ed48990395c639a49370a829345d22d89f24522f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","v8.10.0","v8.11.0"],"number":165933,"url":"https://github.com/elastic/kibana/pull/165933","mergeCommit":{"message":"[Security
Solution] expandable flyout - add isolate host panel (#165933)\n\n##
Summary\r\n\r\nThis new expandable flyout is going GA in `8.10`. One
feature isn't\r\nworking: the `isolate host` from the `take action`
button in the right\r\nsection footer. The code was added in
this\r\n[PR](#153903) but isolate
host\r\ntesting must have been overlooked.\r\n\r\nThis PR adds the
functionality to the new expandable flyout, by creating\r\na new panel,
displayed similarly to the right panel is
today.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17276605/abd99323-616b-4474-a21c-29ce3c56dd1a\r\n\r\nhttps://github.com//pull/165933\r\n\r\n###
TODO\r\n\r\n- [ ] verify logic\r\n- [ ] add unit tests\r\n- [ ] add
Cypress tests\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Ashokaditya
<ashokaditya@elastic.co>","sha":"ed48990395c639a49370a829345d22d89f24522f"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165933","number":165933,"mergeCommit":{"message":"[Security
Solution] expandable flyout - add isolate host panel (#165933)\n\n##
Summary\r\n\r\nThis new expandable flyout is going GA in `8.10`. One
feature isn't\r\nworking: the `isolate host` from the `take action`
button in the right\r\nsection footer. The code was added in
this\r\n[PR](#153903) but isolate
host\r\ntesting must have been overlooked.\r\n\r\nThis PR adds the
functionality to the new expandable flyout, by creating\r\na new panel,
displayed similarly to the right panel is
today.\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/17276605/abd99323-616b-4474-a21c-29ce3c56dd1a\r\n\r\nhttps://github.com//pull/165933\r\n\r\n###
TODO\r\n\r\n- [ ] verify logic\r\n- [ ] add unit tests\r\n- [ ] add
Cypress tests\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Ashokaditya
<ashokaditya@elastic.co>","sha":"ed48990395c639a49370a829345d22d89f24522f"}}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@christineweng christineweng christineweng approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Threat Hunting:Investigations Security Solution Investigations Team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PhilippeOberti @kibana-ci @kibanamachine @ashokaditya @christineweng @kevinlog