Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip "Customize time" test #166239

Closed
wants to merge 4 commits into from
Closed

[Discover] Unskip "Customize time" test #166239

wants to merge 4 commits into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 12, 2023 •
edited
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 12, 2023
@jughosta jughosta self-assigned this Sep 12, 2023
@jughosta
Copy link
Contributor Author

jughosta commented Sep 12, 2023 •
edited
Loading

Closing in favour of #165454

Nvm, we still need to unskip our test.

@jughosta jughosta closed this Sep 12, 2023
@jughosta jughosta deleted the 104578-unskip-customize-time-test branch September 12, 2023 14:53
@jughosta jughosta restored the 104578-unskip-customize-time-test branch September 12, 2023 15:01
@jughosta jughosta reopened this Sep 12, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@davismcphee davismcphee mentioned this pull request Sep 14, 2023
Merged
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Sep 21, 2023
@gsoldevila
Rely on elastic#166239 for handling the opening of the super date picker
28132c7
@jughosta jughosta closed this Sep 25, 2023
@jughosta jughosta deleted the 104578-unskip-customize-time-test branch September 25, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
2 participants
@jughosta @kibana-ci