Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v88.3.0 #166676

Merged
merged 18 commits into from
Sep 20, 2023
Merged

Upgrade EUI to v88.3.0 #166676

merged 18 commits into from
Sep 20, 2023

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Sep 18, 2023

⚠️ NOTE: This PR is a copy of #166292 (which was reverted due to failing Storybook builds). This is the same exact PR but with Storybook building fixed.


EUI 88.2.0 ➡️ 88.3.0

88.3.0

  • EuiGlobalToastList now shows a "Clear all" button by default once above a certain number of toasts (defaults to 3). This threshold is configurable with the showClearAllButtonAt prop (#7111)
  • Added an optional onClearAllToasts callback to EuiGlobalToastList (#7111)
  • Added the value, onChange, and onCancel props that allow EuiInlineEdit to be used as a controlled component (#7157)
  • Added grabOmnidirectional, transitionLeftIn, transitionLeftOut, transitionTopIn, and transitionTopOut icon glyphs. (#7168)

Bug fixes

  • Fixed EuiInlineEdit components to correctly spread ...rest attributes to the parent wrapper (#7157)
  • Fixed EuiListGroupItem to correctly render the extraAction button when showToolTip is also passed (#7159)

Dependency updates

  • Updated @hello-pangea/dnd to v16.3.0 (#7125)
  • Updated @types/lodash to v4.14.198 (#7126)

Accessibility

  • EuiAccordion now correctly respects reduced motion settings (#7161)
  • EuiAccordion now shows a focus outline to keyboard users around its revealed children on open (#7161)

CSS-in-JS conversions

  • Converted EuiSplitPanel to Emotion (#7172)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.11.0 ci:build-storybooks labels Sep 18, 2023
@@ -77,6 +77,7 @@
"yarn": "^1.22.19"
},
"resolutions": {
"**/@hello-pangea/dnd": "16.2.0",
Copy link
Contributor Author

@cee-chen cee-chen Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkajtoch @breehall

I don't love this but I don't see an easy way around this. We were able to update Kibana's base webpack config and Cypress webpack config to use the optional chaining babel plugin on the distributed dnd dependency, but Storybook just won't take my updated rule no matter what I try.

I think it's related to this issue: storybookjs/storybook#14292 and the fact that Kibana is still on Webpack v4. I don't think we can upgrade Kibana past 16.2.0 until it's on Webpack v5.

Edit: I tried the linked issue's suggestion of pinning acorn to 8.x, which fixed Storybook but unfortunately broke Kibana's build script. So we're stuck with pinning @hello-pangea/dnd until Kibana is on Webpack v5 I think.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / console app console context menu should toggle auto indent when auto indent button is clicked
  • [job] [logs] FTR Configs #34 / core plugins application deep links navigation should navigate to Home when navlink is clicked inside the defined category group
  • [job] [logs] FTR Configs #5 / serverless search UI empty pages "before all" hook for "should show search specific empty page in discover"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2214 2213 -1
fileUpload 219 217 -2
maps 966 964 -2
total -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 53.1KB 53.1KB -6.0B
aiops 593.7KB 593.7KB -6.0B
alerting 65.1KB 65.1KB -3.0B
apm 3.7MB 3.7MB -26.0B
canvas 1011.6KB 1011.6KB -3.0B
cloudDataMigration 3.6KB 3.6KB -3.0B
console 403.5KB 403.5KB -3.0B
controls 188.7KB 188.7KB -3.0B
crossClusterReplication 146.2KB 146.2KB -6.0B
dashboard 354.1KB 354.1KB -6.0B
dataViewFieldEditor 173.6KB 173.6KB -3.0B
dataViewManagement 117.4KB 117.4KB -6.0B
dataVisualizer 605.9KB 605.9KB -3.0B
devTools 5.5KB 5.5KB -3.0B
enterpriseSearch 2.6MB 2.6MB -174.0B
eventAnnotation 176.7KB 176.7KB -6.0B
exploratoryView 200.9KB 200.9KB -3.0B
expressionLegacyMetricVis 11.9KB 11.9KB -3.0B
expressionMetricVis 4.6KB 4.6KB -3.0B
expressionPartitionVis 32.1KB 32.1KB -3.0B
filesManagement 89.5KB 89.4KB -3.0B
fileUpload 958.1KB 957.5KB -629.0B
fleet 1.2MB 1.2MB -20.0B
graph 387.5KB 387.5KB -3.0B
grokdebugger 8.9KB 8.9KB -3.0B
home 164.2KB 164.2KB -3.0B
imageEmbeddable 50.3KB 50.3KB -3.0B
indexLifecycleManagement 142.5KB 142.5KB -3.0B
indexManagement 538.1KB 538.1KB -6.0B
infra 2.0MB 2.0MB -21.0B
ingestPipelines 360.8KB 360.8KB -19.0B
inputControlVis 49.9KB 49.9KB -9.0B
kibanaOverview 44.9KB 44.9KB -3.0B
kubernetesSecurity 38.6KB 38.6KB -3.0B
licenseManagement 44.5KB 44.5KB -3.0B
lists 146.6KB 146.6KB -3.0B
logExplorer 221.1KB 221.1KB -6.0B
logstash 31.2KB 31.1KB -3.0B
management 42.4KB 42.4KB -3.0B
maps 2.8MB 2.8MB -628.0B
ml 3.5MB 3.5MB -3.0B
monitoring 462.4KB 462.4KB -3.0B
observabilityAIAssistant 180.9KB 180.8KB -77.0B
observabilityOnboarding 408.9KB 408.9KB -8.0B
profiling 342.8KB 342.8KB -3.0B
remoteClusters 75.8KB 75.8KB -3.0B
rollup 112.6KB 112.6KB -6.0B
savedObjectsFinder 5.0KB 5.0KB -3.0B
searchprofiler 159.0KB 159.0KB -3.0B
securitySolution 12.8MB 12.8MB -18.0B
securitySolutionEss 42.4KB 42.4KB -3.0B
sessionView 391.9KB 391.9KB -3.0B
share 5.5KB 5.5KB -3.0B
snapshotRestore 259.3KB 259.3KB -3.0B
stackAlerts 204.0KB 204.0KB -9.0B
synthetics 861.2KB 861.1KB -9.0B
telemetryManagementSection 9.8KB 9.8KB -6.0B
transform 397.0KB 397.0KB -3.0B
triggersActionsUi 1.4MB 1.4MB -88.0B
upgradeAssistant 155.1KB 155.1KB -3.0B
uptime 480.5KB 480.5KB -6.0B
ux 166.0KB 166.0KB -3.0B
visTypeTimeseries 511.7KB 511.7KB -15.0B
visTypeVega 1.8MB 1.8MB -3.0B
visTypeVislib 339.7KB 339.7KB -3.0B
visualizations 265.5KB 265.5KB -3.0B
watcher 163.3KB 163.3KB -3.0B
total -1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 15.9KB 15.9KB -3.0B
advancedSettings 9.5KB 9.5KB -3.0B
alerting 19.8KB 19.8KB -3.0B
apm 38.3KB 38.3KB -3.0B
bfetch 6.9KB 6.9KB -3.0B
canvas 13.4KB 13.4KB -3.0B
cases 152.1KB 152.1KB -6.0B
charts 44.9KB 44.9KB -6.0B
cloud 5.7KB 5.7KB -3.0B
cloudChat 5.3KB 5.3KB -3.0B
cloudChatProvider 2.0KB 2.0KB -3.0B
cloudDataMigration 4.4KB 4.4KB -3.0B
cloudDefend 8.8KB 8.8KB -6.0B
cloudExperiments 7.0KB 7.0KB -3.0B
cloudFullStory 3.5KB 3.5KB -3.0B
cloudGainsight 3.5KB 3.5KB -3.0B
cloudLinks 8.9KB 8.9KB -3.0B
cloudSecurityPosture 15.4KB 15.4KB -6.0B
console 26.7KB 26.7KB -3.0B
contentManagement 7.6KB 7.6KB -3.0B
controls 37.4KB 37.4KB -3.0B
core 365.8KB 366.1KB +352.0B
customIntegrations 10.3KB 10.2KB -3.0B
dashboard 33.9KB 33.9KB -3.0B
dashboardEnhanced 15.2KB 15.2KB -6.0B
data 407.5KB 407.5KB -6.0B
dataViewEditor 12.7KB 12.7KB -6.0B
dataViewFieldEditor 25.2KB 25.2KB -6.0B
dataViews 45.9KB 45.9KB -3.0B
dataVisualizer 23.0KB 23.0KB -3.0B
devTools 11.1KB 11.1KB -3.0B
discover 30.9KB 30.9KB -6.0B
discoverEnhanced 5.9KB 5.9KB -3.0B
embeddable 78.6KB 78.6KB -6.0B
embeddableEnhanced 6.7KB 6.7KB -3.0B
enterpriseSearch 39.8KB 39.8KB -3.0B
esUiShared 156.2KB 156.2KB -6.0B
eventAnnotation 21.4KB 21.4KB -3.0B
exploratoryView 44.2KB 44.2KB -6.0B
expressionError 5.2KB 5.2KB -3.0B
expressionGauge 14.5KB 14.5KB -3.0B
expressionHeatmap 14.7KB 14.7KB -3.0B
expressionRepeatImage 6.2KB 6.2KB -3.0B
expressionRevealImage 6.2KB 6.2KB -3.0B
expressions 98.1KB 98.1KB -6.0B
expressionShape 20.8KB 20.8KB -3.0B
expressionTagcloud 9.9KB 9.9KB -3.0B
expressionXY 38.0KB 38.0KB -3.0B
features 3.6KB 3.6KB -3.0B
fieldFormats 63.3KB 63.3KB -3.0B
files 10.6KB 10.6KB -3.0B
fileUpload 7.3KB 7.3KB -3.0B
fleet 143.2KB 143.1KB -6.0B
globalSearch 6.3KB 6.3KB -3.0B
globalSearchBar 26.3KB 26.3KB -3.0B
graph 8.0KB 8.0KB -3.0B
guidedOnboarding 27.7KB 27.7KB -3.0B
home 11.5KB 11.5KB -3.0B
imageEmbeddable 8.9KB 8.9KB -3.0B
indexLifecycleManagement 27.1KB 27.1KB -3.0B
indexManagement 32.8KB 32.8KB -3.0B
infra 106.5KB 106.5KB -3.0B
ingestPipelines 13.9KB 13.9KB -3.0B
inputControlVis 5.6KB 5.6KB -3.0B
inspector 21.7KB 21.7KB -3.0B
interactiveSetup 61.2KB 61.2KB -3.0B
kbnUiSharedDeps-css 279.0KB 278.7KB -288.0B
kbnUiSharedDeps-npmDll 6.3MB 6.2MB -10.3KB
kbnUiSharedDeps-srcJs 2.2MB 2.2MB -4.0B
kibanaReact 54.3KB 54.3KB -6.0B
kibanaUtils 73.6KB 73.6KB -6.0B
lens 37.0KB 37.0KB -6.0B
licenseManagement 11.1KB 11.1KB -3.0B
licensing 9.7KB 9.7KB -6.0B
lists 3.8KB 3.8KB -3.0B
logsShared 219.4KB 219.3KB -9.0B
logstash 14.0KB 14.0KB -3.0B
management 10.6KB 10.6KB -3.0B
maps 46.5KB 46.5KB -6.0B
mapsEms 5.7KB 5.7KB -3.0B
ml 74.6KB 74.6KB -3.0B
monitoring 24.1KB 24.1KB -6.0B
navigation 9.8KB 9.8KB -6.0B
newsfeed 10.8KB 10.8KB -6.0B
observability 100.1KB 100.0KB -9.0B
observabilityAIAssistant 9.1KB 9.1KB -6.0B
observabilityLogExplorer 13.9KB 13.9KB -6.0B
observabilityOnboarding 5.5KB 5.5KB -3.0B
observabilityShared 44.3KB 44.3KB -6.0B
osquery 51.2KB 51.2KB -6.0B
presentationUtil 36.0KB 36.0KB -6.0B
profiling 23.1KB 23.1KB -3.0B
remoteClusters 8.6KB 8.6KB -3.0B
reporting 43.2KB 43.2KB -6.0B
savedObjects 22.3KB 22.3KB -3.0B
savedObjectsFinder 3.3KB 3.3KB -3.0B
savedObjectsManagement 19.4KB 19.4KB -6.0B
savedObjectsTagging 20.0KB 20.0KB -6.0B
savedObjectsTaggingOss 2.4KB 2.4KB -3.0B
savedSearch 10.9KB 10.9KB -3.0B
screenshotMode 2.0KB 2.0KB -3.0B
searchprofiler 19.5KB 19.5KB -3.0B
security 70.0KB 70.0KB -6.0B
securitySolution 62.5KB 62.5KB -3.0B
securitySolutionServerless 42.1KB 42.1KB -6.0B
serverless 5.5KB 5.4KB -6.0B
serverlessObservability 44.4KB 44.4KB -3.0B
serverlessSearch 31.0KB 30.9KB -6.0B
sessionView 8.1KB 8.1KB -3.0B
share 52.0KB 52.0KB -3.0B
snapshotRestore 27.4KB 27.4KB -3.0B
spaces 24.5KB 24.5KB -6.0B
stackConnectors 36.5KB 36.5KB -6.0B
telemetry 19.4KB 19.4KB -6.0B
telemetryManagementSection 4.3KB 4.3KB -3.0B
textBasedLanguages 5.5KB 5.4KB -6.0B
threatIntelligence 14.0KB 14.0KB -3.0B
timelines 42.6KB 42.6KB -3.0B
transform 18.2KB 18.2KB -3.0B
triggersActionsUi 91.8KB 91.8KB -6.0B
uiActions 20.1KB 20.1KB -3.0B
uiActionsEnhanced 16.8KB 16.8KB -6.0B
unifiedDocViewer 9.8KB 9.8KB -6.0B
unifiedHistogram 6.1KB 6.1KB -3.0B
unifiedSearch 34.8KB 34.8KB -6.0B
upgradeAssistant 20.2KB 20.1KB -3.0B
uptime 22.6KB 22.6KB -3.0B
urlDrilldown 15.5KB 15.5KB -3.0B
urlForwarding 2.6KB 2.6KB -3.0B
usageCollection 5.0KB 5.0KB -3.0B
visDefaultEditor 21.2KB 21.2KB -3.0B
visTypeGauge 10.8KB 10.8KB -6.0B
visTypeHeatmap 10.9KB 10.8KB -6.0B
visTypeMarkdown 7.0KB 7.0KB -6.0B
visTypeMetric 10.5KB 10.5KB -3.0B
visTypePie 8.4KB 8.4KB -6.0B
visTypeTable 16.7KB 16.7KB -3.0B
visTypeTagcloud 6.5KB 6.5KB -6.0B
visTypeTimelion 10.7KB 10.7KB -3.0B
visTypeTimeseries 18.5KB 18.5KB -3.0B
visTypeVega 33.8KB 33.8KB -3.0B
visTypeVislib 12.5KB 12.5KB -3.0B
visTypeXy 28.5KB 28.5KB -6.0B
visualizations 57.1KB 57.1KB -3.0B
watcher 13.5KB 13.5KB -3.0B
total -10.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review September 19, 2023 22:29
@cee-chen cee-chen requested review from a team as code owners September 19, 2023 22:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen
Copy link
Contributor Author

@elastic/kibana-operations Thanks again for your patience with us! 🙇

@jbudz jbudz merged commit 102dbe2 into elastic:main Sep 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2023
@cee-chen cee-chen deleted the eui/88.3.0 branch September 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-storybooks EUI release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants