Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix assertion for delete ingest pipelines api #167451

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Sep 27, 2023

Summary

This PR fixes commented code in delete ingest pipelines api in ML test services.

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.10.3 labels Sep 27, 2023
@qn895 qn895 self-assigned this Sep 27, 2023
@qn895 qn895 requested a review from a team as a code owner September 27, 2023 20:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@qn895 qn895 merged commit f5d223b into elastic:main Sep 28, 2023
9 checks passed
@qn895 qn895 deleted the ml-fix-ingest-pipeline-test branch September 28, 2023 15:54
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.10:
- [ML] Data Frame Analytics trained models: adds functional tests for 'Deploy Model' action (#163886)

Manual backport

To create the backport manually run:

node scripts/backport --pr 167451

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 167451 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 167451 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 167451 locally

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.10.3 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants