-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] fix url check by excluding port #168112
Merged
dmlemeshko
merged 1 commit into
elastic:main
from
dmlemeshko:ftr/fix-url-check-for-navigation
Oct 5, 2023
Merged
[ftr] fix url check by excluding port #168112
dmlemeshko
merged 1 commit into
elastic:main
from
dmlemeshko:ftr/fix-url-check-for-navigation
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v8.9.3
v8.12.0
v8.11.1
release_note:skip
Skip the PR/issue when compiling release notes
FTR
labels
Oct 5, 2023
pheyos
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
## Summary Addressing MKI `commonPage.navigateToUrl()` failures when `actualUrl` contains port value. ``` ✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing -- | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews) ``` Works both on MKI and local serverless run. (cherry picked from commit 6301dc8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
## Summary Addressing MKI `commonPage.navigateToUrl()` failures when `actualUrl` contains port value. ``` ✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing -- | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews) ``` Works both on MKI and local serverless run. (cherry picked from commit 6301dc8)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[ftr] fix url check by excluding port (#168112)](#168112) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T16:28:46Z","message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","v8.9.3","v8.12.0","v8.11.1"],"number":168112,"url":"https://github.com/elastic/kibana/pull/168112","mergeCommit":{"message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.11"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168112","number":168112,"mergeCommit":{"message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[ftr] fix url check by excluding port (#168112)](#168112) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T16:28:46Z","message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","v8.9.3","v8.12.0","v8.11.1"],"number":168112,"url":"https://github.com/elastic/kibana/pull/168112","mergeCommit":{"message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.11"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168112","number":168112,"mergeCommit":{"message":"[ftr] fix url check by excluding port (#168112)\n\n## Summary\r\n\r\nAddressing MKI `commonPage.navigateToUrl()` failures when `actualUrl`\r\ncontains port value.\r\n\r\n```\r\n✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing\r\n--\r\n | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews)\r\n```\r\n\r\nWorks both on MKI and local serverless run.","sha":"6301dc83843d2fad546a02edcef68ad9a6715937"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
## Summary Addressing MKI `commonPage.navigateToUrl()` failures when `actualUrl` contains port value. ``` ✖ fail: Serverless Common UI - Management Data View Management disables scripted fields Scripted fields tab is missing -- | │ Error: retry.try timeout: Error: expected https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud/app/management/kibana/dataViews.includes(https://bk-serverless-ftr-185-elasticsearch-e79c7a.kb.eu-west-1.aws.qa.elastic.cloud:443/app/management/kibana/dataViews) ``` Works both on MKI and local serverless run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing MKI
commonPage.navigateToUrl()
failures whenactualUrl
contains port value.Works both on MKI and local serverless run.