[Security Solution] Unskip rules bulk actions Serverless Cypress tests #168307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
test
release_note:fix
Team:Detections and Resp
maximpn
added
release_note:skip
maximpn
force-pushed
the
unskip-rules-bulk-actions-serverless-cypress-test
branch
from
afecfcf to
06a1e3a
Compare
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
3 similar comments
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@maximpn I think there's something wrong with the changed tests because the |
maximpn
force-pushed
the
unskip-rules-bulk-actions-serverless-cypress-test
branch
2 times, most recently
from
2b00b77 to
1ed17f3
Compare
|
@banderror |
maximpn
force-pushed
the
unskip-rules-bulk-actions-serverless-cypress-test
branch
2 times, most recently
from
1ed17f3 to
da8e814
Compare
banderror
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Why in this file some tests still marked as broken? Can we unskip them?
maximpn
force-pushed
the
unskip-rules-bulk-actions-serverless-cypress-test
branch
2 times, most recently
from
8e01918 to
6f8bca8
Compare
|
Good point @banderror, I unskipped as many tests as possible in https://github.com/banderror/kibana/blob/da8e81434fa7a435b77d84b5532e2c6479dd2e99/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy.ts#L77-L81 and made sure there are no skipped/broken tests in https://github.com/banderror/kibana/blob/11b1bc77a6260d5f59b977607eae4a1f4ab63a0a/x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_data_view.cy.ts#L245-L248. There are two |
maximpn
force-pushed
the
unskip-rules-bulk-actions-serverless-cypress-test
branch
from
6f8bca8 to
54aad79
Compare
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @maximpn |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2023
elastic#168307) **Addresses:** elastic#161540 ## Summary This PR unskips rules bulk actions Serverless Cypress tests (besides role based `bulk_edit_rules_actions.cy.ts`) - `bulk_duplicate_rules.cy.ts` - `bulk_edit_rules.cy.ts` - `bulk_edit_rules_data_view.cy.ts` ## Flaky test runner `detection_response/rule_management/rule_actions/bulk_actions` folder [150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3596) 🟢 (cherry picked from commit 4f91082)
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2023
…ss tests (#168307) (#169322) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Unskip rules bulk actions Serverless Cypress tests (#168307)](#168307) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-18T22:26:55Z","message":"[Security Solution] Unskip rules bulk actions Serverless Cypress tests (#168307)\n\n**Addresses:** https://github.com/elastic/kibana/issues/161540\r\n\r\n## Summary\r\n\r\nThis PR unskips rules bulk actions Serverless Cypress tests (besides role based `bulk_edit_rules_actions.cy.ts`)\r\n\r\n- `bulk_duplicate_rules.cy.ts`\r\n- `bulk_edit_rules.cy.ts`\r\n- `bulk_edit_rules_data_view.cy.ts`\r\n\r\n## Flaky test runner\r\n\r\n\r\n`detection_response/rule_management/rule_actions/bulk_actions` folder [150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3596) 🟢","sha":"4f9108273c3bbdf03af26a8a0d2b7a571311751a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","v8.11.0","v8.12.0"],"number":168307,"url":"https://github.com/elastic/kibana/pull/168307","mergeCommit":{"message":"[Security Solution] Unskip rules bulk actions Serverless Cypress tests (#168307)\n\n**Addresses:** https://github.com/elastic/kibana/issues/161540\r\n\r\n## Summary\r\n\r\nThis PR unskips rules bulk actions Serverless Cypress tests (besides role based `bulk_edit_rules_actions.cy.ts`)\r\n\r\n- `bulk_duplicate_rules.cy.ts`\r\n- `bulk_edit_rules.cy.ts`\r\n- `bulk_edit_rules_data_view.cy.ts`\r\n\r\n## Flaky test runner\r\n\r\n\r\n`detection_response/rule_management/rule_actions/bulk_actions` folder [150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3596) 🟢","sha":"4f9108273c3bbdf03af26a8a0d2b7a571311751a"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168307","number":168307,"mergeCommit":{"message":"[Security Solution] Unskip rules bulk actions Serverless Cypress tests (#168307)\n\n**Addresses:** https://github.com/elastic/kibana/issues/161540\r\n\r\n## Summary\r\n\r\nThis PR unskips rules bulk actions Serverless Cypress tests (besides role based `bulk_edit_rules_actions.cy.ts`)\r\n\r\n- `bulk_duplicate_rules.cy.ts`\r\n- `bulk_edit_rules.cy.ts`\r\n- `bulk_edit_rules_data_view.cy.ts`\r\n\r\n## Flaky test runner\r\n\r\n\r\n`detection_response/rule_management/rule_actions/bulk_actions` folder [150 runs](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3596) 🟢","sha":"4f9108273c3bbdf03af26a8a0d2b7a571311751a"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #161540
Summary
This PR unskips rules bulk actions Serverless Cypress tests (besides role based
bulk_edit_rules_actions.cy.ts)bulk_duplicate_rules.cy.tsbulk_edit_rules.cy.tsbulk_edit_rules_data_view.cy.tsFlaky test runner
detection_response/rule_management/rule_actions/bulk_actionsfolder 150 runs 🟢