Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/ working tests on serverless #168375

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 9, 2023

Summary

In this PR we are making the following changes regarding the tests living in x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/ regarding their execution on the first quality gate for serverless:

  • Unskipped creation.cy.ts
  • Unskipped export.cy.ts

Note that the unskipped tests have been executed several times and are passing consistently :)

Also, the tests that were marked before with .skip remain skipped in both executions.

@MadameSheema MadameSheema changed the title adding templates tests to serverless [Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/ working tests on serverless Oct 9, 2023
@MadameSheema MadameSheema self-assigned this Oct 9, 2023
@MadameSheema MadameSheema added v8.11.0 v8.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team labels Oct 9, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 9, 2023 18:09
@MadameSheema MadameSheema requested a review from a team as a code owner October 9, 2023 18:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added the release_note:skip Skip the PR/issue when compiling release notes label Oct 9, 2023
@MadameSheema MadameSheema enabled auto-merge (squash) October 9, 2023 18:46
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, more serverless tests, thanks @MadameSheema :)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 9, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2023
…/cypress/e2e/investigations/timeline_templates/` working tests on serverless (elastic#168375)

(cherry picked from commit 1eb7b96)
@MadameSheema MadameSheema deleted the maximizing-serverless-coverage/templates branch October 11, 2023 10:44
kibanamachine added a commit that referenced this pull request Oct 11, 2023
…cypress/cypress/e2e/investigations/timeline_templates/` working tests on serverless (#168375) (#168402)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/`
working tests on serverless
(#168375)](#168375)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2023-10-09T19:40:05Z","message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/`
working tests on serverless
(#168375)","sha":"1eb7b9643d505cacdbe296c54e39f981806d00e3","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Investigations","v8.11.0","v8.12.0"],"number":168375,"url":"https://github.com/elastic/kibana/pull/168375","mergeCommit":{"message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/`
working tests on serverless
(#168375)","sha":"1eb7b9643d505cacdbe296c54e39f981806d00e3"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168375","number":168375,"mergeCommit":{"message":"[Security
Solution] Unskipping
`x-pack/test/security_solution_cypress/cypress/e2e/investigations/timeline_templates/`
working tests on serverless
(#168375)","sha":"1eb7b9643d505cacdbe296c54e39f981806d00e3"}}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
…/cypress/e2e/investigations/timeline_templates/` working tests on serverless (elastic#168375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants