-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.11] [Data Discovery] Unskip and fix flaky Serverless examples tests (#168422) #168664
Merged
davismcphee
merged 2 commits into
elastic:8.11
from
davismcphee:backport/8.11/pr-168422
Oct 13, 2023
Merged
[8.11] [Data Discovery] Unskip and fix flaky Serverless examples tests (#168422) #168664
davismcphee
merged 2 commits into
elastic:8.11
from
davismcphee:backport/8.11/pr-168422
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#168422) ## Summary This PR unskips and fixes the remaining flaky Serverless examples tests. Resolves elastic#165730. Resolves elastic#165735. Resolves elastic#165624. Resolves elastic#165623. Resolves elastic#165635. Resolves elastic#165938. Resolves elastic#165927. Resolves elastic#165882. Resolves elastic#165797. Resolves elastic#167939. Resolves elastic#165503. Resolves elastic#165502. Resolves elastic#165379. Flaky test runs: - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430 🟢 - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455 🔴 - x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478 🟢 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8bd40bc) # Conflicts: # x-pack/test_serverless/functional/test_suites/common/examples/search_examples/search_example.ts
9 tasks
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
davismcphee
added
the
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
label
Oct 12, 2023
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@elastic/kibana-data-discovery Looks like I need reapproval on this backport since it was done manually. |
jughosta
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.11
:Questions ?
Please refer to the Backport tool documentation