Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [Data Discovery] Unskip and fix flaky Serverless examples tests (#168422) #168664

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

davismcphee
Copy link
Contributor

Backport

This will backport the following commits from main to 8.11:

Questions ?

Please refer to the Backport tool documentation

…tic#168422)

## Summary

This PR unskips and fixes the remaining flaky Serverless examples tests.

Resolves elastic#165730.
Resolves elastic#165735.
Resolves elastic#165624.
Resolves elastic#165623.
Resolves elastic#165635.
Resolves elastic#165938.
Resolves elastic#165927.
Resolves elastic#165882.
Resolves elastic#165797.
Resolves elastic#167939.
Resolves elastic#165503.
Resolves elastic#165502.
Resolves elastic#165379.

Flaky test runs:
- x300:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430
🟢
- x300:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455
🔴
- x100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478
🟢

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 8bd40bc)

# Conflicts:
#	x-pack/test_serverless/functional/test_suites/common/examples/search_examples/search_example.ts
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@davismcphee davismcphee added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee requested a review from a team October 12, 2023 20:27
@davismcphee
Copy link
Contributor Author

@elastic/kibana-data-discovery Looks like I need reapproval on this backport since it was done manually.

@davismcphee davismcphee merged commit 5dc69b4 into elastic:8.11 Oct 13, 2023
2 checks passed
@davismcphee davismcphee deleted the backport/8.11/pr-168422 branch October 17, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants