Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inspector] Fix Typo #168849

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Inspector] Fix Typo #168849

merged 1 commit into from
Oct 13, 2023

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Oct 13, 2023 •
edited by kibanamachine
Loading

Summary

Fixes a typo in the inspector shard failure flyout

@ThomThomson ThomThomson added Feature:Inspector Inspector infrastructure and implementations Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.11.0 v8.12.0 labels Oct 13, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #61 / visualize app visual builder "before each" hook for "should display correct data for the selected interval"
  • [job] [logs] FTR Configs #61 / visualize app visual builder Time Series Elastic charts "after all" hook for "should display correct data for the selected interval"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inspector 26.2KB 26.2KB -2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review October 13, 2023 15:51
@ThomThomson ThomThomson requested a review from a team as a code owner October 13, 2023 15:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter
Heenawter approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this 🙇

@ThomThomson ThomThomson merged commit 58df0aa into elastic:main Oct 13, 2023
15 checks passed
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2023
@ThomThomson
[Inspector] Fix Typo (elastic#168849)
e9619cf 
Fixes a typo in the inspector shard failure flyout

(cherry picked from commit 58df0aa)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 13, 2023
@kibanamachine @ThomThomson
[8.11] [Inspector] Fix Typo (#168849) (#168872)
4629037 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Inspector] Fix Typo
(#168849)](#168849)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-10-13T15:54:54Z","message":"[Inspector]
Fix Typo (#168849)\n\nFixes a typo in the inspector shard failure
flyout","sha":"58df0aa0d3324ef9c378f9d7026697f8acca29ac","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Inspector","Team:Presentation","loe:small","release_note:skip","impact:low","v8.11.0","v8.12.0"],"number":168849,"url":"https://github.com/elastic/kibana/pull/168849","mergeCommit":{"message":"[Inspector]
Fix Typo (#168849)\n\nFixes a typo in the inspector shard failure
flyout","sha":"58df0aa0d3324ef9c378f9d7026697f8acca29ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168849","number":168849,"mergeCommit":{"message":"[Inspector]
Fix Typo (#168849)\n\nFixes a typo in the inspector shard failure
flyout","sha":"58df0aa0d3324ef9c378f9d7026697f8acca29ac"}}]}]
BACKPORT-->

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@ThomThomson @dej611
[Inspector] Fix Typo (elastic#168849)
ef0dc70 
Fixes a typo in the inspector shard failure flyout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThomThomson @kibana-ci @elasticmachine @kibanamachine @Heenawter