Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-word partial data message #168883

Merged
merged 18 commits into from
Oct 13, 2023

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Oct 13, 2023

Copied from #168613 since @nreese is out and I don't have permission to push to his branch.

Re-wording partial data message to remove the word "wrong".

274308582-f8352529-3dab-43be-b28a-d2eca5891f86

@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0 v8.12.0 labels Oct 13, 2023
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 407.4KB 407.4KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review October 13, 2023 21:29
@ThomThomson ThomThomson requested review from a team as code owners October 13, 2023 21:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2023
Re-words the partial data message to remove the word "wrong".

Co-authored-by: nreese <reese.nathan@elastic.co>
(cherry picked from commit 1c2df62)
kibanamachine added a commit that referenced this pull request Oct 13, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [Re-word partial data message
(#168883)](#168883)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-10-13T21:29:38Z","message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.11.0","v8.12.0"],"number":168883,"url":"https://github.com/elastic/kibana/pull/168883","mergeCommit":{"message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168883","number":168883,"mergeCommit":{"message":"Re-word
partial data message (#168883)\n\nRe-words the partial data message to
remove the word \"wrong\".\r\n\r\nCo-authored-by: nreese
<reese.nathan@elastic.co>","sha":"1c2df62494c2710c96be487595350f73053d5600"}}]}]
BACKPORT-->

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
Re-words the partial data message to remove the word "wrong".

Co-authored-by: nreese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants