update canvas a11y test to import SO not re-create index #168944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
bhavyarm
approved these changes
Oct 16, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2023
) ## Summary Related to elastic#161882 There is no need to re-create `.kibana` index, changing to imported saved objects. (cherry picked from commit a1f360e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2023
) (#169003) # Backport This will backport the following commits from `main` to `8.11`: - [update canvas a11y test to import SO not re-create index (#168944)](#168944) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-16T16:28:43Z","message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","v8.11.1"],"number":168944,"url":"https://github.com/elastic/kibana/pull/168944","mergeCommit":{"message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168944","number":168944,"mergeCommit":{"message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
) ## Summary Related to elastic#161882 There is no need to re-create `.kibana` index, changing to imported saved objects.
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Oct 30, 2023
) ## Summary Related to elastic#161882 There is no need to re-create `.kibana` index, changing to imported saved objects. (cherry picked from commit a1f360e) # Conflicts: # x-pack/test/accessibility/apps/canvas.ts
dmlemeshko
added a commit
that referenced
this pull request
Oct 30, 2023
) (#170113) # Backport This will backport the following commits from `main` to `8.10`: - [update canvas a11y test to import SO not re-create index (#168944)](#168944) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-16T16:28:43Z","message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.11.0","v8.12.0","v8.11.1"],"number":168944,"url":"https://github.com/elastic/kibana/pull/168944","mergeCommit":{"message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/169003","number":169003,"state":"MERGED","mergeCommit":{"sha":"bfbf388bb8e21ab718383e445fcf44edab9e0b37","message":"[8.11] update canvas a11y test to import SO not re-create index (#168944) (#169003)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.11`:\n- [update canvas a11y test to import SO not re-create index\n(#168944)](https://github.com/elastic/kibana/pull/168944)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dzmitry\nLemechko\",\"email\":\"dzmitry.lemechko@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-10-16T16:28:43Z\",\"message\":\"update\ncanvas a11y test to import SO not re-create index (#168944)\\n\\n##\nSummary\\r\\n\\r\\nRelated to\nhttps://github.com//issues/161882\\r\\n\\r\\nThere is no need\nto re-create `.kibana` index, changing to imported\\r\\nsaved\nobjects.\",\"sha\":\"a1f360eac5d538cebd13af795dfdc6e14e944f2a\",\"branchLabelMapping\":{\"^v8.12.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v8.12.0\",\"v8.11.1\"],\"number\":168944,\"url\":\"https://github.com/elastic/kibana/pull/168944\",\"mergeCommit\":{\"message\":\"update\ncanvas a11y test to import SO not re-create index (#168944)\\n\\n##\nSummary\\r\\n\\r\\nRelated to\nhttps://github.com//issues/161882\\r\\n\\r\\nThere is no need\nto re-create `.kibana` index, changing to imported\\r\\nsaved\nobjects.\",\"sha\":\"a1f360eac5d538cebd13af795dfdc6e14e944f2a\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.11\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.12.0\",\"labelRegex\":\"^v8.12.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/168944\",\"number\":168944,\"mergeCommit\":{\"message\":\"update\ncanvas a11y test to import SO not re-create index (#168944)\\n\\n##\nSummary\\r\\n\\r\\nRelated to\nhttps://github.com//issues/161882\\r\\n\\r\\nThere is no need\nto re-create `.kibana` index, changing to imported\\r\\nsaved\nobjects.\",\"sha\":\"a1f360eac5d538cebd13af795dfdc6e14e944f2a\"}},{\"branch\":\"8.11\",\"label\":\"v8.11.1\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>"}},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168944","number":168944,"mergeCommit":{"message":"update canvas a11y test to import SO not re-create index (#168944)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/161882\r\n\r\nThere is no need to re-create `.kibana` index, changing to imported\r\nsaved objects.","sha":"a1f360eac5d538cebd13af795dfdc6e14e944f2a"}}]}] BACKPORT-->
dmlemeshko
deleted the
ftr/update-canvas-tests-to-not-re-create-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #161882
This PR is a part of the general effort to stop modifying Saved Object indexes with esArchiver.
In particular test, esArchiver loads
.kibanaindex with its own mappings, so the default index and its relevant to version mappings will be deleted. We don't want it, changing to simply load test data via SO import.