[8.10] [esArchiver] restrict from modifying saved objects indexes (#169852) #170064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…69852) ## Summary Related to elastic#161882 The goal is to prevent FTR tests from new esArchives that overrides SO indexes. This PR adds the existing archives that re-create Saved Objects indexes into temporary exception list, located in `packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json`. Whenever tests/archives are updated to not modify SO indexes, archive is expected to be removed from the list (progress can be tracked in elastic#169075, elastic#168973, elastic#168969, elastic#168926 ) Load action has a check if index is SO index and if the archive is in the exception list. This will throw error for the new archives, but still work as usual for the existing ones while teams updating the tests. Whenever test is loading archive listed in the exception list, the following warning message is logged: ``` warn x-pack/test/functional/es_archives/data/search_sessions overrides Saved Objects index(es) and placed temporary in the exception list. Please fix the archive and remove it from /Users/dmle/github/kibana/packages/kbn-es-archiver/src/fixtures/override_saved_objects_index/exception_list.json. For more details see: elastic#161882 ``` If the test loads a newly added archive that modifies a Saved Object index (e.g. `.kibana`), esArchiver will throw the error: ``` Error: esArchiver doesn't support modifying the existing Saved Objects index: '.kibana_1', please update its definition in mappings.json ``` (cherry picked from commit 6698810)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Requires #170113 backport to be merged first |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @dmlemeshko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.10:Questions ?
Please refer to the Backport tool documentation