Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Display package root requirements #170478

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 2, 2023

Summary

Resolve #166784

Display when a package require elastic agent to be run as root.

UI Changes

In package details
Screenshot 2023-11-09 at 6 06 57 PM

In package policy create

Screenshot 2023-11-09 at 6 07 06 PM

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet self-assigned this Nov 2, 2023
@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 2, 2023
@nchaulet nchaulet force-pushed the feature-display-package-root-privileges branch from 8c8ec9e to 2390511 Compare November 3, 2023 14:09
@nchaulet nchaulet marked this pull request as ready for review November 7, 2023 17:04
@nchaulet nchaulet requested a review from a team as a code owner November 7, 2023 17:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Nov 7, 2023
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just some suggestions on the copy

nchaulet and others added 3 commits November 7, 2023 13:03
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
…/epm/screens/detail/overview/requirements.tsx

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
…policy/create_package_policy_page/single_page_layout/index.tsx

Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
@nchaulet nchaulet enabled auto-merge (squash) November 7, 2023 18:19
@nchaulet
Copy link
Member Author

nchaulet commented Nov 7, 2023

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Nov 7, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #1 / Timelines shows the different timeline states should show the correct timeline status should show the correct timeline status

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 944 946 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1091 1094 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +1.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fleet 45 46 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 149.3KB 149.7KB +328.0B
Unknown metric groups

API count

id before after diff
fleet 1209 1212 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 34bdce9 into elastic:main Nov 7, 2023
30 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Notify the user if the integration being deployed needs root privileges
6 participants