[@kbn/ui-framework] move ui-framework to a package #17085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
WIP
spalger
force-pushed
the
upgrade/ui-framework-react-router
branch
from
e9e0521 to
ae662bc
Compare
spalger
force-pushed
the
upgrade/ui-framework-react-router
branch
from
ae662bc to
21d57ad
Compare
spalger
force-pushed
the
upgrade/ui-framework-react-router
branch
from
21d57ad to
e839543
Compare
💚 Build Succeeded |
|
@cjcenizal can you please help me verify that the build tasks and such still work as expected? |
|
I'm also fairly confident that all the jest tests are still running, but if you could verify that would be appreciated. |
cjcenizal
suggested changes
Mar 13, 2018
There was a problem hiding this comment.
Great work Spencer! Thanks so much for doing this. The tests and tasks work fine but I found one thing that's broken. It might seem odd, but the doc_site/build directory needs to be checked in with an index.html file inside it for the docs to be served: https://github.com/elastic/kibana/blob/master/ui_framework/doc_site/build/index.html
|
Got it, fixed and updated the .gitignore file to not ignore the index.html file (apparently you have to use the |
💚 Build Succeeded |
kimjoar
approved these changes
Mar 13, 2018
I added some comments, but feel free to skip.| 'import/no-extraneous-dependencies': [ | ||
| 'error', | ||
| { | ||
| devDependencies: true, |
There was a problem hiding this comment.
Why do we need this setup for ui-framework but not for the rest of Kibana? Maybe it's been discussed somewhere (I've been sick the last week, so my brain is still a bit foggy).
Or is it just a "nice addon" to help make it clear?
There was a problem hiding this comment.
I only added it to the ui-framework to help me verify that I was pulling in the right dependencies and making the right things dev/normal deps. I think we could absolutely use this in other places, but I don't think it needs to go into this PR.
| "xml2js": "0.4.19", | ||
| "xmlbuilder": "9.0.4", | ||
| "yeoman-generator": "1.1.1", | ||
| "yo": "2.0.0" |
There was a problem hiding this comment.
I ❤️ THIS CLEANUP SO MUCH!
src/dev/jest/config.js
Outdated
| @@ -44,15 +40,14 @@ export default { | |||
| ], | |||
| modulePathIgnorePatterns: [ | |||
| '__fixtures__/', | |||
| '<rootDir>/packages/kbn-ui-framework/target/', | |||
There was a problem hiding this comment.
Maybe we should just do /target/ here? I felt I had already included that in some PR, but maybe it's one of my active ones 🙈
💚 Build Succeeded |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Mar 13, 2018
* [@kbn/ui-framework] move ui-framework to a package * [@kbn/ui-framework] restore doc_site index.html and fix build task names * [jest] always ignore modules in target dirs
spalger
added a commit
that referenced
this pull request
Mar 13, 2018
|
6.x/6.3: 2013bb9 |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Mar 27, 2018
…lastic#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681.
chrisronline
added a commit
that referenced
this pull request
May 17, 2018
* Not working proto code * More proto code * Work in progress * Just go back to non interactive searching, much easier * This should be on the server * Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)" This reverts commit ef3339b. * Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681. * Use BasicTable properly * Table improvements * Small tweaks to the table * Improvements * Flyout mostly working * Remove in memory table * Getting close * Tweaks * Revamping server code, still need to support editing * Progress * Fix export * Updates and passing functional tests * Better links in relationships flyout * Add skip import option * Fixes around importing and removing unnecessary code * Remove tags for now * Tests for lib/ * Some fixes * Ensure we clear index pattern cache * Parity with master * Revert any changes in package.json * Reset any changes in this file * Move the new argumen to the end to prevent test failures * Fix functional tests * Add relationship tests * Fix tests * API integration tests for relationships * Ensure we're properly waiting for things to happen * Fix test issue * Wait for the table to finish loading instead of the whole page * Tests for objects_table * Componentry tests * Ensure this is grabbing the right field * Update snapshot * Fixes with importing index patterns * PR feedback * PR feedback * PR feedback * Update snapshot * PR feedback * Update snapshot * Respect the savedObjects:perPage config * Updates from PR feedback * More updates from PR feedback * Make this more efficient * Add debugging for functional test failures * Wait longer * Wrap each button accessor with a retry.try * Try wrapping this in a retry.try * Debug * Lets make sure it is visible * Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish * Rewrite this per suggestions from stacey
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 17, 2018
* Not working proto code * More proto code * Work in progress * Just go back to non interactive searching, much easier * This should be on the server * Revert "[@kbn/ui-framework] move ui-framework to a package (elastic#17085)" This reverts commit ef3339b. * Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (elastic#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681. * Use BasicTable properly * Table improvements * Small tweaks to the table * Improvements * Flyout mostly working * Remove in memory table * Getting close * Tweaks * Revamping server code, still need to support editing * Progress * Fix export * Updates and passing functional tests * Better links in relationships flyout * Add skip import option * Fixes around importing and removing unnecessary code * Remove tags for now * Tests for lib/ * Some fixes * Ensure we clear index pattern cache * Parity with master * Revert any changes in package.json * Reset any changes in this file * Move the new argumen to the end to prevent test failures * Fix functional tests * Add relationship tests * Fix tests * API integration tests for relationships * Ensure we're properly waiting for things to happen * Fix test issue * Wait for the table to finish loading instead of the whole page * Tests for objects_table * Componentry tests * Ensure this is grabbing the right field * Update snapshot * Fixes with importing index patterns * PR feedback * PR feedback * PR feedback * Update snapshot * PR feedback * Update snapshot * Respect the savedObjects:perPage config * Updates from PR feedback * More updates from PR feedback * Make this more efficient * Add debugging for functional test failures * Wait longer * Wrap each button accessor with a retry.try * Try wrapping this in a retry.try * Debug * Lets make sure it is visible * Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish * Rewrite this per suggestions from stacey
chrisronline
added a commit
that referenced
this pull request
May 17, 2018
* [Management] Saved objects to React/EUI! (#17426) * Not working proto code * More proto code * Work in progress * Just go back to non interactive searching, much easier * This should be on the server * Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)" This reverts commit ef3339b. * Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681. * Use BasicTable properly * Table improvements * Small tweaks to the table * Improvements * Flyout mostly working * Remove in memory table * Getting close * Tweaks * Revamping server code, still need to support editing * Progress * Fix export * Updates and passing functional tests * Better links in relationships flyout * Add skip import option * Fixes around importing and removing unnecessary code * Remove tags for now * Tests for lib/ * Some fixes * Ensure we clear index pattern cache * Parity with master * Revert any changes in package.json * Reset any changes in this file * Move the new argumen to the end to prevent test failures * Fix functional tests * Add relationship tests * Fix tests * API integration tests for relationships * Ensure we're properly waiting for things to happen * Fix test issue * Wait for the table to finish loading instead of the whole page * Tests for objects_table * Componentry tests * Ensure this is grabbing the right field * Update snapshot * Fixes with importing index patterns * PR feedback * PR feedback * PR feedback * Update snapshot * PR feedback * Update snapshot * Respect the savedObjects:perPage config * Updates from PR feedback * More updates from PR feedback * Make this more efficient * Add debugging for functional test failures * Wait longer * Wrap each button accessor with a retry.try * Try wrapping this in a retry.try * Debug * Lets make sure it is visible * Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish * Rewrite this per suggestions from stacey * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before opening x-pack we either need to remove our usage of react-router v3, which is used by the ui_framework doc site. Rather than make the massive amount of changes necessary to upgrade to react-router v4 this moves the ui_framework into a package so that it is isolated from core Kibana.
All yarn scripts have been updated to continue working as designed, the only real difference is that ui_framework components are now imported from
@kbn/ui-framework/componentsrather thanui_framework/components.