Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #172021

Closed
wants to merge 80 commits into from
Closed

WIP #172021

wants to merge 80 commits into from

Conversation

cee-chen
Copy link
Contributor

v90.0.0v91.0.0

91.0.0

  • Updated the background color of EuiPopovers in dark mode to increase visibility & contrast against other page/panel backgrounds (#7310)
  • Memoized EuiDataGrid to prevent unneeded re-renders (#7324)
  • Added a configurable role prop to EuiAccordion (#7326)
  • Added a configurable role prop to EuiGlobalToastList (#7328)
  • For greater flexibility, EuiSuperDatePicker now allows users to paste ISO 8601, RFC 2822, and Unix timestamps in the Absolute tab input, in addition to timestamps in the dateFormat prop (#7331)
  • Plain text EuiComboBoxes now behave more like a normal text field/input. Backspacing will no longer delete the entire value, and selected values can now be double clicked and copied. (#7332)
  • EuiDataGrid's display settings popover now allows users to clear the "Lines per row" input before typing in a new number (#7338)
  • Improved the UX of EuiSuperDatePicker's Absolute tab for users manually typing in timestamps (#7341)
  • Updated EuiI18ns with multiple tokens to accept dynamic values (#7341)

Bug fixes

  • Fixed EuiComboBox's onSearchChange callback to pass the correct hasMatchingOptions value (#7334)
  • Fixed an EuiSelectableTemplateSitewide bug where the popoverButton behavior would break if passed a non-DOM React wrapper (#7339)

Deprecations

  • EuiPopover: deprecated anchorClassName. Use className instead (#7311)
  • EuiPopover: deprecated buttonRef. Use popoverRef instead (#7311)
  • EuiPopover: removed extra .euiPopover__anchor div wrapper. Target .euiPopover instead if necessary (#7311)
  • Deprecated EuiButtonGroup's name prop. This can safely be removed. (#7325)

Breaking changes

  • Removed deprecated euiPaletteComplimentary - use euiPaletteComplementary Instead (#7333)

Accessibility

  • Updated type="single" EuiButtonGroups to render standard buttons instead of radio buttons under the hood, per recent a11y recommendations (#7325)
  • EuiAccordion now defaults to a less screenreader-noisy group role instead of region. If your accordion contains significant enough content to be a document landmark role, you may re-configure it back to region. (#7326)
  • Reduced screen reader noisiness when sorting EuiDataGrid columns via toolbar (#7327)
  • EuiGlobalToastList now defaults to a log role. If your toasts will always require immediate user action, consider (with caution) using the alert role instead. (#7328)

CSS-in-JS conversions

  • Updated $euiFontFamily and $euiCodeFontFamily to match Emotion fonts (#7332)

tkajtoch and others added 30 commits November 22, 2023 14:25
- no longer present in EUI
- a lot of classNames that are passing either `eui-fullWidth` or `eui-displayBlock` can now be removed entirely with the wrapper gone

- some classes with no corresponding CSS can be removed

- other usages can be converted to `className`
tkajtoch and others added 26 commits November 22, 2023 14:25
…to replace selected characters to fix behavior of recent selenium versions
…re combobox input is always empty before typing
@cee-chen cee-chen added the ci:skip-cypress-osquery Skips osquery cypress checks label Nov 27, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #6 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Security Solution Cypress Tests #3 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Serverless Security Cypress Tests #6 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Security Solution Cypress Tests #3 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Add endpoint exception from rule details with exception items edits an endpoint exception item edits an endpoint exception item
  • [job] [logs] Security Solution Cypress Tests #5 / Add exception using data views from rule details Creates an exception item and close all matching alerts Creates an exception item and close all matching alerts
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add exception using data views from rule details Creates an exception item and close all matching alerts Creates an exception item and close all matching alerts
  • [job] [logs] Security Solution Cypress Tests #5 / Add exception using data views from rule details Creates an exception item and close all matching alerts Creates an exception item and close all matching alerts
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add exception using data views from rule details Creates an exception item and close all matching alerts Creates an exception item and close all matching alerts
  • [job] [logs] Security Solution Cypress Tests #5 / Add exception using data views from rule details Edits an exception item Edits an exception item
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add exception using data views from rule details Edits an exception item Edits an exception item
  • [job] [logs] Security Solution Cypress Tests #5 / Add exception using data views from rule details Edits an exception item Edits an exception item
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / Add exception using data views from rule details Edits an exception item Edits an exception item
  • [job] [logs] Security Solution Cypress Tests #4 / Add/edit exception from rule details existing list and items Edits an exception item Edits an exception item
  • [job] [logs] Security Solution Cypress Tests #4 / Add/edit exception from rule details existing list and items Edits an exception item Edits an exception item
  • [job] [logs] Security Solution Cypress Tests #4 / Add/edit exception from rule details rule without existing exceptions Cannot create an item to add to rule but not shared list as rule has no lists attached Cannot create an item to add to rule but not shared list as rule has no lists attached
  • [job] [logs] Security Solution Cypress Tests #4 / Add/edit exception from rule details rule without existing exceptions Cannot create an item to add to rule but not shared list as rule has no lists attached Cannot create an item to add to rule but not shared list as rule has no lists attached
  • [job] [logs] Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Serverless Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Serverless Osquery Cypress Tests #5 / Alert Event Details - dynamic params should substitute parameters in investigation guide should substitute parameters in investigation guide
  • [job] [logs] Osquery Cypress Tests #6 / Alert Event Details - Response Actions Form adds response actions with osquery with proper validation and form values adds response actions with osquery with proper validation and form values
  • [job] [logs] Serverless Osquery Cypress Tests #6 / Alert Event Details - Response Actions Form adds response actions with osquery with proper validation and form values adds response actions with osquery with proper validation and form values
  • [job] [logs] Osquery Cypress Tests #6 / Alert Event Details - Response Actions Form adds response actions with osquery with proper validation and form values adds response actions with osquery with proper validation and form values
  • [job] [logs] Serverless Osquery Cypress Tests #6 / Alert Event Details - Response Actions Form adds response actions with osquery with proper validation and form values adds response actions with osquery with proper validation and form values
  • [job] [logs] Osquery Cypress Tests #4 / Alert Event Details should be able to add investigation guides to response actions should be able to add investigation guides to response actions
  • [job] [logs] Serverless Osquery Cypress Tests #4 / Alert Event Details should be able to add investigation guides to response actions should be able to add investigation guides to response actions
  • [job] [logs] Osquery Cypress Tests #4 / Alert Event Details should be able to add investigation guides to response actions should be able to add investigation guides to response actions
  • [job] [logs] Serverless Osquery Cypress Tests #4 / Alert Event Details should be able to add investigation guides to response actions should be able to add investigation guides to response actions
  • [job] [logs] Osquery Cypress Tests #3 / ALL - Packs Global packs add proper shard to policies packs config
  • [job] [logs] Serverless Osquery Cypress Tests #2 / ALL - Packs Global packs add proper shard to policies packs config
  • [job] [logs] Osquery Cypress Tests #3 / ALL - Packs Global packs add proper shard to policies packs config
  • [job] [logs] Serverless Osquery Cypress Tests #2 / ALL - Packs Global packs add proper shard to policies packs config
  • [job] [logs] FTR Configs #38 / content management examples Todo app Todo app works
  • [job] [logs] FTR Configs #38 / content management examples Todo app Todo app works
  • [job] [logs] FTR Configs #71 / discover discover field visualize button should visualize correctly text based language queries in Discover
  • [job] [logs] FTR Configs #71 / discover discover field visualize button should visualize correctly text based language queries in Discover
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly. Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly.
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly. Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly.
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly. Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly.
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly. Can add two OR rows and delete the second row. The first row has invalid data and the second row has valid data. The first row is deleted and the second row shifts up correctly.
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search Deletes the first row of data but not the UI elements and the text defaults back to the placeholder of Search
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row Deletes the first row when you have two rows. Both rows valid rows of "index fields" and valid "indicator index fields". The second row should become the first row
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly
  • [job] [logs] Security Solution Cypress Tests #3 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / indicator match Detection rules, Indicator Match Creating new indicator match rules Indicator mapping Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly Deletes the second row when you have three rows. The first row is valid data, the second row is invalid data, and the third row is valid data. Third row should shift up correctly
  • [job] [logs] FTR Configs #23 / lens app - Agg based Vis Open in Lens XY should convert y-axis positions
  • [job] [logs] FTR Configs #23 / lens app - Agg based Vis Open in Lens XY should convert y-axis positions
  • [job] [logs] FTR Configs #49 / lens app - group 5 lens drag and drop tests keyboard drag and drop should drop a field to workspace
  • [job] [logs] FTR Configs #49 / lens app - group 5 lens drag and drop tests keyboard drag and drop should drop a field to workspace
  • [job] [logs] FTR Configs #16 / machine learning - data visualizer data view management adds new field
  • [job] [logs] FTR Configs #16 / machine learning - data visualizer data view management adds new field
  • [job] [logs] FTR Configs #50 / machine learning - stack management jobs manage spaces add one space should edit job space assignment
  • [job] [logs] FTR Configs #50 / machine learning - stack management jobs manage spaces add one space should edit job space assignment
  • [job] [logs] Osquery Cypress Tests #2 / T1 and T2 analysts t1_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Serverless Osquery Cypress Tests #5 / T1 and T2 analysts t1_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Serverless Osquery Cypress Tests #5 / T1 and T2 analysts t1_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Osquery Cypress Tests #2 / T1 and T2 analysts t1_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Osquery Cypress Tests #2 / T1 and T2 analysts t2_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Serverless Osquery Cypress Tests #5 / T1 and T2 analysts t2_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Serverless Osquery Cypress Tests #5 / T1 and T2 analysts t2_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] Osquery Cypress Tests #2 / T1 and T2 analysts t2_analyst- READ + runSavedQueries should be able to play in live queries history should be able to play in live queries history
  • [job] [logs] FTR Configs #3 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range
  • [job] [logs] FTR Configs #17 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range
  • [job] [logs] FTR Configs #83 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range
  • [job] [logs] FTR Configs #3 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range
  • [job] [logs] FTR Configs #17 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range
  • [job] [logs] FTR Configs #83 / Visualizations - Group 3 lens app - TSVB Open in Lens Top N should convert last value mode to reduced time range

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 421 422 +1
apm 1529 1531 +2
infra 1374 1372 -2
maps 1093 1091 -2
ml 1861 1863 +2
securitySolution 4728 4729 +1
securitySolutionServerless 479 480 +1
visTypeVega 310 308 -2
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 385.2KB 385.3KB +96.0B
apm 3.7MB 3.7MB +138.0B
canvas 1013.9KB 1013.9KB -18.0B
cloudSecurityPosture 401.5KB 401.5KB -36.0B
controls 189.8KB 189.6KB -223.0B
dashboard 377.3KB 377.1KB -150.0B
discover 589.4KB 589.4KB -54.0B
enterpriseSearch 2.6MB 2.6MB -108.0B
eventAnnotationListing 196.8KB 196.8KB -16.0B
exploratoryView 203.4KB 203.3KB -120.0B
fleet 1.2MB 1.2MB -60.0B
graph 388.2KB 387.9KB -300.0B
infra 1.9MB 1.9MB -4.7KB
lens 1.4MB 1.4MB -48.0B
maps 2.9MB 2.9MB -4.9KB
ml 3.6MB 3.6MB -481.0B
securitySolution 12.8MB 12.8MB -298.0B
securitySolutionServerless 337.7KB 337.8KB +93.0B
unifiedDocViewer 58.5KB 58.4KB -168.0B
unifiedSearch 213.8KB 213.5KB -255.0B
visTypeTimeseries 511.9KB 511.9KB -18.0B
visTypeVega 1.8MB 1.8MB -4.7KB
total -16.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
console 29.2KB 29.1KB -150.0B
core 374.6KB 374.8KB +186.0B
embeddable 78.5KB 78.4KB -78.0B
kbnUiSharedDeps-css 256.1KB 255.9KB -273.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -1.6KB
unifiedSearch 35.3KB 35.3KB -36.0B
total -2.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 468 467 -1

Total ESLint disabled count

id before after diff
securitySolution 538 537 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen closed this Nov 29, 2023
@cee-chen cee-chen deleted the eui-v91.x branch December 18, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-cypress-osquery Skips osquery cypress checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants