-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP #172021
Closed
Closed
WIP #172021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer present in EUI
- a lot of classNames that are passing either `eui-fullWidth` or `eui-displayBlock` can now be removed entirely with the wrapper gone - some classes with no corresponding CSS can be removed - other usages can be converted to `className`
…milarly named users" test
…single selection combo boxes
…to replace selected characters to fix behavior of recent selenium versions
…arValueWithKeyboard`
…rks in all browsers
…alternate option
…re combobox input is always empty before typing
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v90.0.0
⏩v91.0.0
91.0.0
EuiPopover
s in dark mode to increase visibility & contrast against other page/panel backgrounds (#7310)EuiDataGrid
to prevent unneeded re-renders (#7324)role
prop toEuiAccordion
(#7326)role
prop toEuiGlobalToastList
(#7328)EuiSuperDatePicker
now allows users to paste ISO 8601, RFC 2822, and Unix timestamps in theAbsolute
tab input, in addition to timestamps in thedateFormat
prop (#7331)EuiComboBox
es now behave more like a normal text field/input. Backspacing will no longer delete the entire value, and selected values can now be double clicked and copied. (#7332)EuiDataGrid
's display settings popover now allows users to clear the "Lines per row" input before typing in a new number (#7338)EuiSuperDatePicker
's Absolute tab for users manually typing in timestamps (#7341)EuiI18n
s with multipletokens
to accept dynamicvalues
(#7341)Bug fixes
EuiComboBox
'sonSearchChange
callback to pass the correcthasMatchingOptions
value (#7334)EuiSelectableTemplateSitewide
bug where thepopoverButton
behavior would break if passed a non-DOM React wrapper (#7339)Deprecations
EuiPopover
: deprecatedanchorClassName
. UseclassName
instead (#7311)EuiPopover
: deprecatedbuttonRef
. UsepopoverRef
instead (#7311)EuiPopover
: removed extra.euiPopover__anchor
div wrapper. Target.euiPopover
instead if necessary (#7311)EuiButtonGroup
'sname
prop. This can safely be removed. (#7325)Breaking changes
euiPaletteComplimentary
- useeuiPaletteComplementary
Instead (#7333)Accessibility
type="single"
EuiButtonGroup
s to render standard buttons instead of radio buttons under the hood, per recent a11y recommendations (#7325)EuiAccordion
now defaults to a less screenreader-noisygroup
role instead ofregion
. If your accordion contains significant enough content to be a document landmark role, you may re-configure it back toregion
. (#7326)EuiDataGrid
columns via toolbar (#7327)EuiGlobalToastList
now defaults to alog
role. If your toasts will always require immediate user action, consider (with caution) using thealert
role instead. (#7328)CSS-in-JS conversions
$euiFontFamily
and$euiCodeFontFamily
to match Emotion fonts (#7332)