-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLOs] Configuration inspect api and flyout #173723
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
x-pack/plugins/synthetics/public/apps/synthetics/components/certificates/cert_monitors.tsx
Outdated
Show resolved
Hide resolved
…rtificates/cert_monitors.tsx
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingest pipelines changes LGTM
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@@ -114,6 +114,42 @@ const createSLORoute = createObservabilityServerRoute({ | |||
}, | |||
}); | |||
|
|||
const inspectSLORoute = createObservabilityServerRoute({ | |||
endpoint: 'POST /internal/api/observability/slos/_inspect 2023-10-31', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahzad31 Out of curiosity, I have seen this 2023-10-31
in the other routes as well and I wanted to ask what is it about (my guess is api versioning?) and how do we know which date to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a kibana API version, for now that's the only version allowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ It's definitely an api versioning thing but I was on maternity leave when this was fully implemented and I'd like to understand it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it LGTM!
I have one question. We show the SLO Inspect
button on the Edit SLO detail page. Does it make sense to show it on the View SLO detail page as well?
We can probably add it in a follow up in cards view and details view. |
## Summary It will show all the associated configs at one place in json form, configuration, ingest pipeline config, roll up transform and summary transform config !! Motivation is to understand things while onboarding devs to slo and during normal development. https://github.com/elastic/kibana/assets/3505601/a22ad292-ba59-4145-989e-80803b6a1e3e
Summary
It will show all the associated configs at one place in json form, configuration, ingest pipeline config, roll up transform and summary transform config !!
Motivation is to understand things while onboarding devs to slo and during normal development.
inspect.mov