[UnifiedSearch] Expose QueryStringInput via plugin contract #173810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
/ci |
|
/ci |
shahzad31
added
the
release_note:skip
botelastic
bot
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
qn895
approved these changes
Dec 29, 2023
|
ML changes LGTM (tested and reviewed |
jloleysens
approved these changes
Jan 2, 2024
nreese
approved these changes
Jan 2, 2024
drewdaemon
reviewed
Jan 2, 2024
Comment on lines
161
to
198
| it('should render search bar and submit queries', async () => { | ||
| await mountSearchBar(); | ||
|
|
||
| await waitForIndexPatternFetch(); | ||
|
|
||
| act(() => { | ||
| instance.find(QueryStringInput).prop('onChange')!({ language: 'lucene', query: 'testQuery' }); | ||
| }); | ||
|
|
||
| act(() => { | ||
| instance.find('form').simulate('submit', { preventDefault: () => {} }); | ||
| }); | ||
|
|
||
| expect(dispatchSpy).toHaveBeenCalledWith({ | ||
| type: 'x-pack/graph/workspace/SUBMIT_SEARCH', | ||
| payload: 'testQuery', | ||
| }); | ||
| }); | ||
|
|
||
| it('should translate kql query into JSON dsl', async () => { | ||
| await mountSearchBar(); | ||
|
|
||
| await waitForIndexPatternFetch(); | ||
|
|
||
| act(() => { | ||
| instance.find(QueryStringInput).prop('onChange')!({ language: 'kuery', query: 'test: abc' }); | ||
| }); | ||
|
|
||
| act(() => { | ||
| instance.find('form').simulate('submit', { preventDefault: () => {} }); | ||
| }); | ||
|
|
||
| const parsedQuery = JSON.parse(dispatchSpy.mock.calls[0][0].payload); | ||
| expect(parsedQuery).toEqual({ | ||
| bool: { should: [{ match: { test: 'abc' } }], minimum_should_match: 1 }, | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Why have these tests been removed?
There was a problem hiding this comment.
@drewdaemon i have restored these tests
drewdaemon
approved these changes
Jan 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Jan 4, 2024
…173810) ## Summary Expose QueryStringInput via plugin contract this will make sure deps are handled by the component itself. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose QueryStringInput via plugin contract this will make sure deps are handled by the component itself.