Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[security solution] fix darkMode access #173894

Merged
merged 6 commits into from
Jan 4, 2024
Merged

[security solution] fix darkMode access #173894

merged 6 commits into from
Jan 4, 2024

Conversation

pgayvallet
Copy link
Contributor

Summary

Part of #173529

Adapt theme access based on uiSettings.get('theme:darkMode') with the correct approach of using core.theme or the useDarkMode react hook.

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v8.13.0 labels Dec 22, 2023
@pgayvallet pgayvallet mentioned this pull request Dec 22, 2023
Closed
@pgayvallet
Copy link
Contributor Author

/ci

1 similar comment
@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet marked this pull request as ready for review December 22, 2023 15:21
@pgayvallet pgayvallet requested review from a team as code owners December 22, 2023 15:21
@stephmilovic
Copy link
Contributor

@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PhilippeOberti
PhilippeOberti approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and code LGTM for the Threat Hunting Investigations team, thanks for making the change for us!

@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet enabled auto-merge (squash) January 4, 2024 07:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.3MB 11.3MB -149.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 64.3KB 64.2KB -56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit c7f15fc into elastic:main Jan 4, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pgayvallet @stephmilovic @kibana-ci @PhilippeOberti @kibanamachine