-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds link to anomaly detection job creation from the alerting rule form #174016
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/ml/public/alerting/anomaly_detection_rule/advanced_settings.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/alerting/anomaly_detection_rule/ml_anomaly_alert_trigger.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/alerting/anomaly_detection_rule/ml_anomaly_alert_trigger.tsx
Outdated
Show resolved
Hide resolved
Tested and LGTM, but I wonder if it's better to either have the select open the link in another tab, or have a prompt message with the link before the selection box. With the current flow, user would come in, fill out info, select Screen.Recording.2023-12-29.at.10.15.09.movThe spacing before the |
@elasticmachine merge upstream |
hi @qn895, thanks for the feedback!
Kibana is a SPA, so opening the same window is significantly faster and provides a better UX.
It'll consume additional vertical space and require the user to read the warning, while we should have this option available at all times. Having the creation entry directly in the relevant control seems like a better option IMO.
It redirects the user to the Job wizard page, and at the last step of the wizard, we have a button to create an alerting rule, that opens a flyout with a populated job field.
It is controlled by the alerting flyout and looks the same for all alerting rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @darnautov |
Summary
Closes #173654
Adds an option to create a new anomaly detection job from the job selector control.
Checklist