[Fleet] fix output host validator when host url is empty #174086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
the
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
@elasticmachine run elasticsearch-ci/docs |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 2, 2024
) ## Summary Closes elastic#174076 Fix output host url validation when url is empty. To verify: - Go to Add output flyout - Click Add another URL - Delete the second URL box - Expect to see validation message `URL is required` <img width="639" alt="image" src="https://github.com/elastic/kibana/assets/90178898/d5ee45f3-dd7d-43dd-8edf-9a3568b18d0d"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4df6951)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 2, 2024
) (#174091) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] fix output host validator when host url is empty (#174086)](#174086) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-02T15:23:33Z","message":"[Fleet] fix output host validator when host url is empty (#174086)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/174076\r\n\r\nFix output host url validation when url is empty.\r\nTo verify:\r\n- Go to Add output flyout\r\n- Click Add another URL\r\n- Delete the second URL box\r\n- Expect to see validation message `URL is required`\r\n\r\n<img width=\"639\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/d5ee45f3-dd7d-43dd-8edf-9a3568b18d0d\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4df69518821486164b6e3a7b8b3d7bc780457de7","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.0","v8.13.0"],"title":"[Fleet] fix output host validator when host url is empty","number":174086,"url":"https://github.com/elastic/kibana/pull/174086","mergeCommit":{"message":"[Fleet] fix output host validator when host url is empty (#174086)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/174076\r\n\r\nFix output host url validation when url is empty.\r\nTo verify:\r\n- Go to Add output flyout\r\n- Click Add another URL\r\n- Delete the second URL box\r\n- Expect to see validation message `URL is required`\r\n\r\n<img width=\"639\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/d5ee45f3-dd7d-43dd-8edf-9a3568b18d0d\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4df69518821486164b6e3a7b8b3d7bc780457de7"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174086","number":174086,"mergeCommit":{"message":"[Fleet] fix output host validator when host url is empty (#174086)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/174076\r\n\r\nFix output host url validation when url is empty.\r\nTo verify:\r\n- Go to Add output flyout\r\n- Click Add another URL\r\n- Delete the second URL box\r\n- Expect to see validation message `URL is required`\r\n\r\n<img width=\"639\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/d5ee45f3-dd7d-43dd-8edf-9a3568b18d0d\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"4df69518821486164b6e3a7b8b3d7bc780457de7"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #174076
Fix output host url validation when url is empty.
To verify:
URL is requiredChecklist
Delete any items that are not applicable to this PR.