Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Replace deprecated node-sass with sass #174114

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jan 2, 2024

patrykkopycinski and others added 4 commits January 2, 2024 11:59
The previous PR elastic#161813 was
reverted due to the broken webpack config

elastic@eef1afc

---------

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
@jbudz jbudz added the backport label Jan 2, 2024
@jbudz
Copy link
Member Author

jbudz commented Jan 2, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Jan 2, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Jan 2, 2024

buildkite test this

@jbudz jbudz requested a review from a team January 2, 2024 21:59
@jbudz jbudz marked this pull request as ready for review January 2, 2024 21:59
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "false" and their admin callouts should not show up On Rule Details page "before each" hook for "We show 1 primary callout"
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "null" and their admin callouts should not show up On Rule Details page "before each" hook for "We show 1 primary callout"
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Detections home page We show the need admin primary callout
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Rule Details page "before each" hook for "We show 1 primary callout"
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #3 / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Rules Management page We show 1 primary callout of need admin

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 874.4KB 874.4KB -12.0B
canvas 1.0MB 1.0MB -108.0B
dashboard 181.3KB 181.2KB -30.0B
dataEnhanced 46.6KB 46.6KB -16.0B
dataVisualizer 526.8KB 526.7KB -84.0B
discover 364.0KB 363.8KB -198.0B
enterpriseSearch 1.4MB 1.4MB -400.0B
esUiShared 7.0KB 7.0KB -12.0B
expressionError 17.5KB 17.5KB -32.0B
expressionMetricVis 10.6KB 10.6KB -8.0B
expressionTagcloud 8.5KB 8.5KB -8.0B
fleet 630.5KB 630.5KB -8.0B
graph 334.9KB 334.9KB -20.0B
home 82.9KB 82.8KB -44.0B
indexLifecycleManagement 157.4KB 157.3KB -64.0B
indexManagement 525.1KB 525.1KB -28.0B
indexPatternEditor 121.3KB 121.3KB -44.0B
indexPatternFieldEditor 151.3KB 151.2KB -104.0B
indexPatternManagement 79.6KB 79.6KB -8.0B
ingestPipelines 452.6KB 452.6KB -56.0B
inputControlVis 83.6KB 83.5KB -24.0B
kibanaLegacy 110.3KB 110.2KB -16.0B
kibanaReact 218.6KB 219.0KB +384.0B
lens 1.0MB 1.0MB -302.0B
management 8.9KB 8.9KB -8.0B
maps 2.7MB 2.7MB -68.0B
ml 3.3MB 3.3MB +34.0B
monitoring 454.2KB 454.1KB -92.0B
observability 361.2KB 361.1KB -56.0B
presentationUtil 43.1KB 43.0KB -24.0B
regionMap 175.1KB 175.1KB -8.0B
remoteClusters 84.3KB 84.3KB -8.0B
rollup 129.6KB 129.6KB -8.0B
savedObjectsManagement 89.1KB 89.1KB -8.0B
savedObjectsTagging 42.3KB 42.3KB -16.0B
security 518.1KB 518.1KB -56.0B
spaces 166.4KB 166.4KB -48.0B
stackAlerts 159.5KB 159.5KB -8.0B
tileMap 179.8KB 179.8KB -8.0B
triggersActionsUi 813.7KB 814.1KB +424.0B
uiActionsEnhanced 128.3KB 128.2KB -16.0B
upgradeAssistant 186.9KB 186.9KB -32.0B
visDefaultEditor 152.8KB 152.8KB -36.0B
visTypeMarkdown 6.4KB 6.4KB -8.0B
visTypePie 51.1KB 51.1KB -8.0B
visTypeTable 17.9KB 17.9KB -16.0B
visTypeTimelion 93.4KB 93.4KB -8.0B
visTypeTimeseries 680.3KB 680.2KB -86.0B
visTypeVega 1.7MB 1.7MB -84.0B
visTypeVislib 379.4KB 379.5KB +18.0B
visTypeXy 62.4KB 62.4KB -8.0B
visualizations 73.4KB 73.3KB -56.0B
visualize 53.5KB 53.4KB -32.0B
total -1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
banners 7.2KB 7.2KB -8.0B
charts 57.8KB 57.7KB -24.0B
console 16.0KB 16.0KB -24.0B
core 312.7KB 312.6KB -92.0B
data 455.5KB 455.6KB +86.0B
devTools 10.1KB 10.1KB -8.0B
embeddable 69.9KB 69.9KB -6.0B
esUiShared 123.6KB 123.6KB -12.0B
expressions 114.4KB 114.4KB -8.0B
fieldFormats 46.8KB 46.7KB -8.0B
globalSearchBar 21.8KB 21.8KB -16.0B
indexManagement 37.0KB 37.0KB +8.0B
indexPatternEditor 11.5KB 11.4KB -8.0B
inspector 24.7KB 24.7KB -16.0B
kibanaOverview 22.3KB 22.2KB -116.0B
kibanaReact 80.9KB 80.8KB -96.0B
licenseManagement 11.0KB 11.0KB -8.0B
mapsLegacy 47.0KB 47.0KB -8.0B
navigation 9.4KB 9.4KB -8.0B
painlessLab 13.0KB 13.0KB -16.0B
presentationUtil 42.2KB 42.1KB -32.0B
savedObjects 31.1KB 31.1KB -8.0B
searchprofiler 34.5KB 34.4KB -26.0B
security 51.4KB 51.4KB -8.0B
share 54.2KB 54.2KB -8.0B
snapshotRestore 28.9KB 28.9KB -8.0B
transform 15.6KB 15.6KB -8.0B
watcher 14.6KB 14.6KB -8.0B
total -494.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit e3d3326 into elastic:7.17 Jan 3, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants