Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Enterprise Search] Reword E5 model description #174171

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[ML][Enterprise Search] Reword E5 model description #174171

merged 1 commit into from
Jan 3, 2024

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Jan 3, 2024 •
edited by kibanamachine
Loading

Summary

Adding "third party" to E5 ML model description as per legal requirements.

Screenshot 2024-01-03 at 09 11 25 Screenshot 2024-01-03 at 09 12 04

Checklist

@demjened demjened added :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) Team:EnterpriseSearch v8.12.0 v8.12.1 v8.13.0 labels Jan 3, 2024
@demjened
Copy link
Contributor Author

demjened commented Jan 3, 2024

/ci

@demjened demjened marked this pull request as ready for review January 3, 2024 15:03
@demjened demjened requested a review from a team as a code owner January 3, 2024 15:03
@demjened demjened requested a review from a team January 3, 2024 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +11.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@demjened demjened merged commit c706de0 into main Jan 3, 2024
34 checks passed
@demjened demjened deleted the demjened/reword-e5-model-description branch January 3, 2024 16:09
@kibanamachine kibanamachine mentioned this pull request Jan 3, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 3, 2024
@demjened
[ML][Enterprise Search] Reword E5 model description (elastic#174171)
e1285af 
## Summary

Adding "third party" to E5 ML model description as per legal
requirements.

<img width="1372" alt="Screenshot 2024-01-03 at 09 11 25"
src="https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb">
<img width="960" alt="Screenshot 2024-01-03 at 09 12 04"
src="https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

(cherry picked from commit c706de0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 3, 2024
@kibanamachine @demjened
[8.12] [ML][Enterprise Search] Reword E5 model description (#174171) (#…
4ba26bc 
…174197)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ML][Enterprise Search] Reword E5 model description
(#174171)](#174171)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Adam
Demjen","email":"demjened@gmail.com"},"sourceCommit":{"committedDate":"2024-01-03T16:08:58Z","message":"[ML][Enterprise
Search] Reword E5 model description (#174171)\n\n##
Summary\r\n\r\nAdding \"third party\" to E5 ML model description as per
legal\r\nrequirements.\r\n\r\n<img width=\"1372\" alt=\"Screenshot
2024-01-03 at 09 11
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb\">\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-03 at 09 12
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"c706de0078b7475fe931ac9d30aaf3de3a49a5ca","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","Team:EnterpriseSearch","v8.12.0","v8.12.1","v8.13.0"],"title":"[ML][Enterprise
Search] Reword E5 model
description","number":174171,"url":"https://github.com/elastic/kibana/pull/174171","mergeCommit":{"message":"[ML][Enterprise
Search] Reword E5 model description (#174171)\n\n##
Summary\r\n\r\nAdding \"third party\" to E5 ML model description as per
legal\r\nrequirements.\r\n\r\n<img width=\"1372\" alt=\"Screenshot
2024-01-03 at 09 11
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb\">\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-03 at 09 12
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"c706de0078b7475fe931ac9d30aaf3de3a49a5ca"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174171","number":174171,"mergeCommit":{"message":"[ML][Enterprise
Search] Reword E5 model description (#174171)\n\n##
Summary\r\n\r\nAdding \"third party\" to E5 ML model description as per
legal\r\nrequirements.\r\n\r\n<img width=\"1372\" alt=\"Screenshot
2024-01-03 at 09 11
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb\">\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-03 at 09 12
04\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)","sha":"c706de0078b7475fe931ac9d30aaf3de3a49a5ca"}}]}]
BACKPORT-->

Co-authored-by: Adam Demjen <demjened@gmail.com>
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 4, 2024
@demjened @nreese
[ML][Enterprise Search] Reword E5 model description (elastic#174171)
3c8d245 
## Summary

Adding "third party" to E5 ML model description as per legal
requirements.

<img width="1372" alt="Screenshot 2024-01-03 at 09 11 25"
src="https://github.com/elastic/kibana/assets/14224983/29522e9a-d532-45da-93bd-efed6a1090eb">
<img width="960" alt="Screenshot 2024-01-03 at 09 12 04"
src="https://github.com/elastic/kibana/assets/14224983/1e5c2128-7111-4bdf-b1a5-8fe89b450a4e">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch Team:ML Team label for ML (also use :ml) v8.12.0 v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@demjened @elasticmachine @kibana-ci @kibanamachine @TattdCodeMonkey @darnautov