[Legacy Controls] Decouple DEPRECATION_BADGE action from Embeddable framework
#175928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Feature:Embedding
|
/ci |
…com:heenawter/kibana into migrate-deprecation-badge-action_2024-01-30
|
/ci |
Heenawter
changed the title
DEPRECATION_BADGE action from Embeddable framework
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
approved these changes
Jan 31, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Heenawter |
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
… framework (elastic#175928) Part of elastic#175138 ## Summary This PR decouples the `DEPRECATION_BADGE` action (which is used specifically for the legacy input controls panel) from Embeddable framework by migrating to sets of composable interfaces. **Testing:** Since the legacy input control vis is deprecated and doesn't show up in the "Add panel" menu anymore, you need to navigate to `<base url>/app/visualize#/create?type=input_control_vis` in order to create this panel type for testing. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
… framework (elastic#175928) Part of elastic#175138 ## Summary This PR decouples the `DEPRECATION_BADGE` action (which is used specifically for the legacy input controls panel) from Embeddable framework by migrating to sets of composable interfaces. **Testing:** Since the legacy input control vis is deprecated and doesn't show up in the "Add panel" menu anymore, you need to navigate to `<base url>/app/visualize#/create?type=input_control_vis` in order to create this panel type for testing. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #175138
Summary
This PR decouples the
DEPRECATION_BADGEaction (which is used specifically for the legacy input controls panel) from Embeddable framework by migrating to sets of composable interfaces.Testing:
Since the legacy input control vis is deprecated and doesn't show up in the "Add panel" menu anymore, you need to navigate to
<base url>/app/visualize#/create?type=input_control_visin order to create this panel type for testing.For maintainers